Skip to content

Commit 38fcf17

Browse files
kgpaifacebook-github-bot
authored andcommitted
build(ci): Build metrics job failing due to build type check (facebookincubator#12132)
Summary: Build metrics job fails since it checks for builds to be 'debug' 'release', these are now 'debug-shared', 'debug-static' etc. Going to remove this check so we have more flexibility for the future. cc: https://github.com/facebookincubator/velox/actions/runs/12879960789/job/35908254047 Pull Request resolved: facebookincubator#12132 Reviewed By: bikramSingh91 Differential Revision: D68447876 Pulled By: kgpai fbshipit-source-id: 7805bb7d608db06e13a3bf047a76643de94a7d42
1 parent 54c6d9e commit 38fcf17

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

scripts/build-metrics.py

-4
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,6 @@ def __init__(
4545
result_fields_append: Dict[str, Any] = {},
4646
) -> None:
4747
self.size_file = Path(size_file)
48-
if build_type not in ["debug", "release"]:
49-
raise ValueError(f"Build type '{build_type}' is not valid!")
5048
self.build_type = build_type
5149
super().__init__(command, result_fields_override, result_fields_append)
5250

@@ -112,8 +110,6 @@ def __init__(
112110
result_fields_append: Dict[str, Any] = {},
113111
) -> None:
114112
self.ninja_log = Path(ninja_log)
115-
if build_type not in ["debug", "release"]:
116-
raise ValueError(f"Build type '{build_type}' is not valid!")
117113
self.build_type = build_type
118114
super().__init__(command, result_fields_override, result_fields_append)
119115

0 commit comments

Comments
 (0)