build: Do not enable all components when testing is enabled (facebookincubator#11896)

Summary:
The goal is to improve the developer experience. If I want to build wave tests,
I want to be able to only build the corresponding tests by disabling unrelated
components such as Spark functions, TPC-H connector, etc. However, the current CMake setup enables these components when testing is enabled.
All of these components except for examples are enabled by default.

Pull Request resolved: facebookincubator#11896

Reviewed By: Yuhta

Differential Revision: D67910097

Pulled By: kevinwilfong

fbshipit-source-id: cc932b9397a6cb649ab12c0c1e1860dca75d4ff8

Author: majetideepak

.github/workflows/linux-build-base.yml

@@ -86,6 +86,7 @@ jobs:
         run: |
           EXTRA_CMAKE_FLAGS=(
             "-DVELOX_ENABLE_BENCHMARKS=ON"
+            "-DVELOX_ENABLE_EXAMPLES=ON"
             "-DVELOX_ENABLE_ARROW=ON"
             "-DVELOX_ENABLE_PARQUET=ON"
             "-DVELOX_ENABLE_HDFS=ON"
@@ -160,7 +161,7 @@ jobs:
           VELOX_DEPENDENCY_SOURCE: BUNDLED
           ICU_SOURCE: SYSTEM
           MAKEFLAGS: "NUM_THREADS=8 MAX_HIGH_MEM_JOBS=4 MAX_LINK_JOBS=3"
-          EXTRA_CMAKE_FLAGS: "-DVELOX_ENABLE_ARROW=ON -DVELOX_ENABLE_PARQUET=ON"
+          EXTRA_CMAKE_FLAGS: "-DVELOX_ENABLE_ARROW=ON -DVELOX_ENABLE_PARQUET=ON -DVELOX_ENABLE_EXAMPLES=ON"
         run: |
           if [[ "${USE_CLANG}" = "true" ]]; then export CC=/usr/bin/clang-15; export CXX=/usr/bin/clang++-15; fi
           make debug

CMakeLists.txt

@@ -136,7 +136,7 @@ option(VELOX_ENABLE_S3 "Build S3 Connector" OFF)
 option(VELOX_ENABLE_GCS "Build GCS Connector" OFF)
 option(VELOX_ENABLE_ABFS "Build Abfs Connector" OFF)
 option(VELOX_ENABLE_HDFS "Build Hdfs Connector" OFF)
-option(VELOX_ENABLE_PARQUET "Enable Parquet support" OFF)
+option(VELOX_ENABLE_PARQUET "Enable Parquet support" ON)
 option(VELOX_ENABLE_ARROW "Enable Arrow support" OFF)
 option(VELOX_ENABLE_REMOTE_FUNCTIONS "Enable remote function support" OFF)
 option(VELOX_ENABLE_CCACHE "Use ccache if installed." ON)
@@ -173,19 +173,6 @@ if(${VELOX_BUILD_MINIMAL} OR ${VELOX_BUILD_MINIMAL_WITH_DWIO})
   set(VELOX_ENABLE_SUBSTRAIT OFF)
 endif()
 
-if(${VELOX_BUILD_TESTING})
-  # Enable all components to build testing binaries
-  set(VELOX_ENABLE_PRESTO_FUNCTIONS ON)
-  set(VELOX_ENABLE_EXPRESSION ON)
-  set(VELOX_ENABLE_EXEC ON)
-  set(VELOX_ENABLE_AGGREGATES ON)
-  set(VELOX_ENABLE_HIVE_CONNECTOR ON)
-  set(VELOX_ENABLE_TPCH_CONNECTOR ON)
-  set(VELOX_ENABLE_SPARK_FUNCTIONS ON)
-  set(VELOX_ENABLE_EXAMPLES ON)
-  set(VELOX_ENABLE_PARQUET ON)
-endif()
-
 if(${VELOX_ENABLE_BENCHMARKS})
   set(VELOX_ENABLE_BENCHMARKS_BASIC ON)
 endif()