Skip to content

Commit f6cfb19

Browse files
committed
fix: correct order of arguments for merging pacts
1 parent 9fdcc57 commit f6cfb19

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

lib/pact_broker/pacts/service.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ def merge_pact params
5959
consumer_version = version_repository.find_by_pacticipant_id_and_number_or_create consumer.id, params[:consumer_version_number]
6060
existing_pact = pact_repository.find_by_version_and_provider(consumer_version.id, provider.id)
6161

62-
params.merge!(json_content: Merger.merge_pacts(params[:json_content], existing_pact.json_content))
62+
params.merge!(json_content: Merger.merge_pacts(existing_pact.json_content, params[:json_content]))
6363

6464
update_pact params, existing_pact
6565
end

spec/features/merge_pact_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
let(:merged_pact_content) { load_fixture('a_consumer-a_provider-merged.json') }
3030

3131
before do
32-
TestDataBuilder.new.create_pact_with_hierarchy("A Consumer", "1.2.3", "A Provider", existing_pact_content).and_return(:pact)
32+
TestDataBuilder.new.create_pact_with_hierarchy("A Consumer", "1.2.3", "A Provider", existing_pact_content)
3333
end
3434

3535
it "returns a 200 Success" do

spec/fixtures/a_consumer-a_provider-merged.json

+4-4
Original file line numberDiff line numberDiff line change
@@ -7,23 +7,23 @@
77
},
88
"interactions": [
99
{
10-
"description" : "a request for something",
10+
"description" : "another request for something",
1111
"providerState": null,
1212
"request": {
1313
"method": "get",
14-
"path" : "/something"
14+
"path" : "/something_else"
1515
},
1616
"response": {
1717
"status": 200,
1818
"body" : "something"
1919
}
2020
},
2121
{
22-
"description" : "another request for something",
22+
"description" : "a request for something",
2323
"providerState": null,
2424
"request": {
2525
"method": "get",
26-
"path" : "/something_else"
26+
"path" : "/something"
2727
},
2828
"response": {
2929
"status": 200,

0 commit comments

Comments
 (0)