fix: return correct "latest" verification when a verification has been published for a pact with a revision

Author: bethesque

lib/pact_broker/domain/verification.rb

@@ -54,7 +54,7 @@ def untagged
         end
 
         def latest
-          reverse_order(:consumer_version_order, :number).limit(1)
+          reverse_order(:consumer_version_order, :revision_number, :number).limit(1)
         end
       end
 

spec/lib/pact_broker/verifications/repository_spec.rb

@@ -101,6 +101,25 @@ module Verifications
       end
 
       describe "#find_latest_verification_for" do
+        context "when there is a revision" do
+          before do
+            TestDataBuilder.new
+              .create_provider("Provider1")
+              .create_consumer("Consumer1")
+              .create_consumer_version("1.2.3")
+              .create_pact
+              .create_verification(number: 1, provider_version: "2.3.4")
+              .revise_pact
+              .create_verification(number: 1, provider_version: "7.8.9")
+          end
+
+          subject { Repository.new.find_latest_verification_for("Consumer1", "Provider1")}
+
+          it "finds the latest verifications for the given consumer version" do
+            expect(subject.provider_version).to eq "7.8.9"
+          end
+        end
+
         context "when no tag is specified" do
           before do
             TestDataBuilder.new