feat: change badge timeout message from error to warning

Author: bethesque

lib/pact_broker/badges/service.rb

@@ -84,8 +84,11 @@ def dynamic_svg left_text, right_text, color
         begin
           response = do_request(uri)
           response.code == '200' ? response.body : nil
+        rescue Net::OpenTimeout => e
+          logger.warn "Timeout retrieving badge from #{uri} #{e.class} - #{e.message}"
+          nil
         rescue StandardError => e
-          logger.error "Error retrieving badge from #{uri} due to #{e.class} - #{e.message}"
+          log_error e, "Error retrieving badge from #{uri}"
           nil
         end
       end

spec/lib/pact_broker/badges/service_spec.rb

@@ -219,6 +219,25 @@ module Service
           end
         end
 
+        context "when a timeout exception is raised connecting to the shields.io server" do
+          before do
+            allow(Net::HTTP).to receive(:start).and_raise(Net::OpenTimeout)
+          end
+
+          it "logs a warning rather than an error as this will happen reasonably often" do
+            expect(logger).to receive(:warn).with(/Timeout retrieving badge from.*shield.*Net::OpenTimeout/)
+            subject
+          end
+
+          it "returns a static image" do
+            expect(subject).to include ">pact</"
+          end
+
+          it "does not cache the response" do
+            expect(Service::CACHE.size).to eq 0
+          end
+        end
+
         context "when an exception is raised connecting to the shields.io server" do
           before do
             allow(Net::HTTP).to receive(:start).and_raise("an error")