Skip to content

Commit c8a8194

Browse files
committed
feat(webhooks): do not show backtrace in webhook test execution response
1 parent d90c455 commit c8a8194

File tree

3 files changed

+2
-7
lines changed

3 files changed

+2
-7
lines changed

lib/pact_broker/api/decorators/webhook_execution_result_decorator.rb

-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ module Decorators
88
class WebhookExecutionResultDecorator < BaseDecorator
99
class ErrorDecorator < BaseDecorator
1010
property :message
11-
property :backtrace
1211
end
1312

1413
class HTTPRequestDecorator < BaseDecorator

spec/features/execute_webhook_spec.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,8 @@
8282

8383
subject { post path; last_response }
8484

85-
it "returns a 500 response" do
86-
expect(subject.status).to be 500
85+
it "returns a 200 response" do
86+
expect(subject.status).to be 200
8787
end
8888

8989
it "does not save a TriggeredWebhook" do

spec/lib/pact_broker/api/decorators/webhook_execution_result_decorator_spec.rb

-4
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,6 @@ module Decorators
4343
it "includes the message" do
4444
expect(subject[:error][:message]).to eq 'message'
4545
end
46-
47-
it "includes the backtrace" do
48-
expect(subject[:error][:backtrace]).to eq ['blah','blah']
49-
end
5046
end
5147

5248
context "when there is a request" do

0 commit comments

Comments
 (0)