Skip to content

Commit ad8da50

Browse files
committed
feat: elegantly handle long service names in index.
1 parent d3217c8 commit ad8da50

File tree

3 files changed

+13
-7
lines changed

3 files changed

+13
-7
lines changed

lib/pact_broker/ui/view_models/index_item.rb

+3-3
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,11 @@ def provider_name
2222
end
2323

2424
def consumer_version_number
25-
short_version_number(@relationship.consumer_version_number)
25+
@relationship.consumer_version_number
2626
end
2727

2828
def provider_version_number
29-
short_version_number(@relationship.provider_version_number)
29+
@relationship.provider_version_number
3030
end
3131

3232
def tag_names
@@ -145,4 +145,4 @@ def short_version_number version_number
145145
end
146146
end
147147
end
148-
end
148+
end

lib/pact_broker/ui/views/index/show-with-tags.haml

+4-4
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,14 @@
1818
%th.consumer
1919
Consumer
2020
%span.glyphicon.glyphicon-sort.relationships-sort
21-
%th.tag
21+
%th.consumer-version-number
2222
Version
2323
%span.glyphicon.glyphicon-sort.relationships-sort
2424
%th.pact{ style: 'width: 40px' }
2525
%th.provider
2626
Provider
2727
%span.glyphicon.glyphicon-sort.relationships-sort
28-
%th.tag
28+
%th.provider-version-number
2929
Version
3030
%span.glyphicon.glyphicon-sort.relationships-sort
3131
%th
@@ -41,7 +41,7 @@
4141
%td.consumer
4242
%a{:href => index_item.consumer_group_url }
4343
= index_item.consumer_name
44-
%td
44+
%td.consumer-version-number
4545
= index_item.consumer_version_number
4646
%span{style: 'color:gray'}
4747
= index_item.tag_names
@@ -51,7 +51,7 @@
5151
%td.provider
5252
%a{ href: index_item.provider_group_url }
5353
= index_item.provider_name
54-
%td
54+
%td.provider-version-number
5555
= index_item.provider_version_number
5656
%td
5757
= index_item.publication_date_of_latest_pact.gsub("about ", "")

public/stylesheets/index.css

+6
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
}
55

66
.table-striped>tbody>tr>td.consumer, .table-striped>thead>tr>th.consumer {
7+
padding: 2px;
78
border-right: none;
89
}
910

@@ -49,6 +50,11 @@ body { padding-top: 10px; }
4950

5051
.consumer, .provider {
5152
text-align: center;
53+
word-wrap: break-word;
54+
}
55+
56+
.consumer-version-number, .provider-version-number {
57+
word-wrap: break-word;
5258
}
5359

5460
span.pact {

0 commit comments

Comments
 (0)