feat(index): enable pagination feature

Author: bethesque

lib/pact_broker/ui/controllers/index.rb

@@ -15,14 +15,16 @@ class Index < Base
             tags = params[:tags] == 'true' ? true : [*params[:tags]].compact
           end
           page_number = params[:page]&.to_i || 1
-          page_size = params[:pageSize]&.to_i || 30
+          # Make page size smaller for data intensive query
+          page_size = params[:pageSize]&.to_i || ( params[:tags] == true ? 30 : 100)
           options = {
             tags: tags,
             page_number: page_number,
             page_size: page_size
           }
 
-          options[:optimised] = true if params[:optimised] == 'true'
+          # TODO remove this code when verified
+          options[:optimised] = true unless params[:optimised] == 'false'
           index_items = ViewDomain::IndexItems.new(index_service.find_index_items(options))
 
           page = tags ? :'index/show-with-tags' : :'index/show'

spec/lib/pact_broker/ui/controllers/index_spec.rb

@@ -38,9 +38,18 @@ module Controllers
             end
 
             context "when pagination parameters are not present" do
-              it "passes through default pagination parameters to the search" do
-                expect(PactBroker::Index::Service).to receive(:find_index_items).with(hash_including(page_number: 1, page_size: 30))
-                get "/"
+              context "when tags=true" do
+                it "passes through default pagination parameters to the search with page_size=30" do
+                  expect(PactBroker::Index::Service).to receive(:find_index_items).with(hash_including(page_number: 1, page_size: 30))
+                  get "/", { tags: 'true' }
+                end
+              end
+
+              context "when not tags=true" do
+                it "passes through default pagination parameters to the search with page_size=100" do
+                  expect(PactBroker::Index::Service).to receive(:find_index_items).with(hash_including(page_number: 1, page_size: 100))
+                  get "/"
+                end
               end
             end