Skip to content

Commit 94da4c7

Browse files
committed
feat(index page): truncate git shas in table
1 parent 16a0524 commit 94da4c7

File tree

1 file changed

+13
-5
lines changed

1 file changed

+13
-5
lines changed

lib/pact_broker/ui/view_models/relationship.rb

+13-5
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,11 @@ def provider_name
2222
end
2323

2424
def consumer_version_number
25-
@relationship.consumer_version_number
25+
short_version_number(@relationship.consumer_version_number)
2626
end
2727

2828
def provider_version_number
29-
@relationship.provider_version_number
29+
short_version_number(@relationship.provider_version_number)
3030
end
3131

3232
def tag_names
@@ -117,11 +117,11 @@ def warning?
117117
def verification_tooltip
118118
case @relationship.verification_status
119119
when :success
120-
"Successfully verified by #{provider_name} (v#{@relationship.latest_verification_provider_version_number})"
120+
"Successfully verified by #{provider_name} (v#{short_version_number(@relationship.latest_verification_provider_version_number)})"
121121
when :stale
122-
"Pact has changed since last successful verification by #{provider_name} (v#{@relationship.latest_verification_provider_version_number})"
122+
"Pact has changed since last successful verification by #{provider_name} (v#{short_version_number(@relationship.latest_verification_provider_version_number)})"
123123
when :failed
124-
"Verification by #{provider_name} (v#{@relationship.latest_verification_provider_version_number}) failed"
124+
"Verification by #{provider_name} (v#{short_version_number(@relationship.latest_verification_provider_version_number)}) failed"
125125
else
126126
nil
127127
end
@@ -133,6 +133,14 @@ def <=> other
133133
provider_name.downcase <=> other.provider_name.downcase
134134
end
135135

136+
def short_version_number version_number
137+
return "" if version_number.nil?
138+
if version_number.size > 12
139+
version_number[0..12] + "..."
140+
else
141+
version_number
142+
end
143+
end
136144
end
137145
end
138146
end

0 commit comments

Comments
 (0)