feat: changed configuration property name from 'enable_badge_resources' to 'enable_public_badge_access'

Author: bethesque

lib/pact_broker/configuration.rb

@@ -20,8 +20,6 @@ class Configuration
     attr_accessor :enable_public_badge_access, :shields_io_base_url
     attr_writer :logger
 
-    alias_method :enable_badge_resources=, :enable_public_badge_access=
-
     def initialize
       @before_resource_hook = ->(resource){}
       @after_resource_hook = ->(resource){}
@@ -110,7 +108,7 @@ def after_resource &block
 
     def enable_badge_resources= enable_badge_resources
       puts "Pact Broker configuration property `enable_badge_resources` is deprecated. Please use `enable_public_badge_access`"
-      enable_public_badge_access= enable_badge_resources
+      self.enable_public_badge_access = enable_badge_resources
     end
 
     def save_to_database