Skip to content

Commit 82b59ef

Browse files
committed
feat: include pact revision number and verification number in badge svg comment
1 parent 8fb28ee commit 82b59ef

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

lib/pact_broker/api/resources/badge.rb

+3-1
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,10 @@ def initials
5858

5959
def comment
6060
consumer_version_number = pact ? pact.consumer_version_number : "?"
61+
pact_revision = pact ? pact.revision_number : "?"
6162
provider_version_number = latest_verification ? latest_verification.provider_version_number : "?"
62-
"<!-- #{identifier_from_path[:consumer_name]} version #{consumer_version_number} #{identifier_from_path[:provider_name]} version #{provider_version_number} -->\n"
63+
verification_number = latest_verification ? latest_verification.number : "?"
64+
"<!-- #{identifier_from_path[:consumer_name]} version #{consumer_version_number} revision #{pact_revision} #{identifier_from_path[:provider_name]} version #{provider_version_number} number #{verification_number} -->\n"
6365
end
6466
end
6567
end

spec/lib/pact_broker/api/resources/badge_spec.rb

+3-3
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@ module Resources
1616
allow(PactBroker::Verifications::Status).to receive(:new).and_return(verification_status)
1717
end
1818

19-
let(:pact) { instance_double("PactBroker::Domain::Pact", consumer: consumer, provider: provider, consumer_version_number: "2") }
19+
let(:pact) { instance_double("PactBroker::Domain::Pact", consumer: consumer, provider: provider, consumer_version_number: "2", revision_number: "1") }
2020
let(:consumer) { double('consumer') }
2121
let(:provider) { double('provider') }
22-
let(:verification) { double("verification", provider_version_number: "3") }
22+
let(:verification) { double("verification", provider_version_number: "3", number: "7") }
2323
let(:verification_status) { instance_double("PactBroker::Verifications::Status", to_sym: :verified) }
2424

2525

@@ -86,7 +86,7 @@ module Resources
8686
end
8787

8888
it "returns a comment with the consumer and provider numbers" do
89-
expect(subject.body).to include "<!-- consumer version 2 provider version 3 -->"
89+
expect(subject.body).to include "<!-- consumer version 2 revision 1 provider version 3 number 7 -->"
9090
end
9191

9292
context "when the label param is specified" do

0 commit comments

Comments
 (0)