feat: move $.message to $.error.message in error response body

Author: bethesque

lib/pact_broker/api/resources/error_handler.rb

@@ -11,9 +11,9 @@ class ErrorHandler
         def self.call e, request, response
           logger.error e
           logger.error e.backtrace
-          response_body = { :message => e.message }
+          response_body = { error: { :message => e.message } }
           if PactBroker.configuration.show_backtrace_in_error_response?
-            response_body[:backtrace] = e.backtrace
+            response_body[:error][:backtrace] = e.backtrace
           end
           response.body = response_body.to_json
           report(e, request) if reportable?(e)

spec/lib/pact_broker/api/resources/error_handler_spec.rb

@@ -40,6 +40,14 @@ module Resources
             end
           end
 
+          it "creates a json error response body" do
+            expect(response).to receive(:body=) do | body |
+              expect(JSON.parse(body)['error']).to include 'message' => 'test error'
+            end
+            subject
+          end
+
+
           context "when show_backtrace_in_error_response? is true" do
             before do
               allow(PactBroker.configuration).to receive(:show_backtrace_in_error_response?).and_return(true)

spec/lib/pact_broker/api/resources/pacticipant_spec.rb

@@ -55,12 +55,7 @@ module Resources
 
           it "returns an error message" do
             subject
-            expect(response_body[:message]).to eq "An error"
-          end
-
-          it "returns the backtrace" do
-            subject
-            expect(response_body[:backtrace]).to be_instance_of(Array)
+            expect(response_body[:error][:message]).to eq "An error"
           end
         end
       end

spec/lib/pact_broker/api/resources/tag_spec.rb

@@ -63,12 +63,7 @@ module Resources
 
             it "returns an error message" do
               subject
-              expect(response_body[:message]).to eq "An error"
-            end
-
-            it "returns the backtrace" do
-              subject
-              expect(response_body[:backtrace]).to be_instance_of(Array)
+              expect(response_body[:error][:message]).to eq "An error"
             end
           end
         end