fix: gracefully handle two requests coming in at the same time to create the same pacticipant

Author: bethesque

lib/pact_broker/api/resources/pacticipant.rb

@@ -34,7 +34,7 @@ def from_json
           if pacticipant
             @pacticipant = pacticipant_service.update params_with_string_keys.merge('name' => pacticipant_name)
           else
-            @pacticipant = pacticipant_service.create params_with_string_keys.merge('name' => pacticipant_name)
+            @pacticipant = pacticipant_service.create params.merge(:name => pacticipant_name)
             response.headers["Location"] = pacticipant_url(base_url, pacticipant)
           end
           response.body = to_json

lib/pact_broker/api/resources/pacticipants.rb

@@ -32,7 +32,7 @@ def post_is_create?
         end
 
         def from_json
-          created_model = pacticipant_service.create params_with_string_keys
+          created_model = pacticipant_service.create(params)
           response.body = decorator_for(created_model).to_json(user_options: decorator_context)
         end
 

lib/pact_broker/pacticipants/repository.rb

@@ -41,6 +41,9 @@ def find_by_name_or_create name
         end
       end
 
+      # Need to be able to handle two calls that make the pacticipant at the same time.
+      # TODO raise error if attributes apart from name are different, because this indicates that
+      # the second request is not at the same time.
       def create args
         PactBroker::Domain::Pacticipant.dataset.insert_ignore.insert(
           name: args[:name],

lib/pact_broker/pacticipants/service.rb

@@ -58,17 +58,15 @@ def self.find_pacticipant_repository_url_by_pacticipant_name name
       end
 
       def self.update params
+        # TODO move this to the repository!
         pacticipant = pacticipant_repository.find_by_name(params.fetch('name'))
         PactBroker::Api::Decorators::PacticipantDecorator.new(pacticipant).from_hash(params)
         pacticipant.save
         pacticipant_repository.find_by_name(params.fetch('name'))
       end
 
       def self.create params
-        pacticipant = PactBroker::Domain::Pacticipant.new
-        PactBroker::Api::Decorators::PacticipantDecorator.new(pacticipant).from_hash(params)
-        pacticipant.save
-        pacticipant
+        pacticipant_repository.create(params)
       end
 
       def self.delete name

spec/lib/pact_broker/api/resources/pacticipants_spec.rb

@@ -47,7 +47,7 @@ module Resources
 
           context "with valid JSON" do
             it "creates the pacticipant" do
-              expect(PactBroker::Pacticipants::Service).to receive(:create).with('name' => 'New Consumer')
+              expect(PactBroker::Pacticipants::Service).to receive(:create).with(:name => 'New Consumer')
               subject
             end