Skip to content

Commit 700f699

Browse files
committed
feat: change error logs to info logs
1 parent b28359f commit 700f699

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

lib/pact_broker/api/resources/base_resource.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ def invalid_json?
127127
JSON.parse(request_body, PACT_PARSING_OPTIONS) #Not load! Otherwise it will try to load Ruby classes.
128128
false
129129
rescue StandardError => e
130-
logger.error "Error parsing JSON #{e} - #{request_body}"
130+
logger.info "Error parsing JSON #{e} - #{request_body}"
131131
set_json_error_message "Error parsing JSON - #{e.message}"
132132
response.headers['Content-Type'] = 'application/hal+json;charset=utf-8'
133133
true

lib/pact_broker/webhooks/job.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ def handle_failure
6565
reschedule_job
6666
update_triggered_webhook_status TriggeredWebhook::STATUS_RETRYING
6767
else
68-
logger.error "Failed to execute webhook #{triggered_webhook.webhook_uuid} after #{retry_schedule.size + 1} attempts."
68+
logger.info "Failed to execute webhook #{triggered_webhook.webhook_uuid} after #{retry_schedule.size + 1} attempts."
6969
update_triggered_webhook_status TriggeredWebhook::STATUS_FAILURE
7070
end
7171
end

spec/lib/pact_broker/webhooks/job_spec.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -118,8 +118,8 @@ module Webhooks
118118
end
119119

120120
it "logs that it has failed" do
121-
allow(Job.logger).to receive(:error)
122-
expect(Job.logger).to receive(:error).with(/Failed to execute/)
121+
allow(Job.logger).to receive(:info)
122+
expect(Job.logger).to receive(:info).with(/Failed to execute/)
123123
subject
124124
end
125125

0 commit comments

Comments
 (0)