Skip to content

Commit 5aa668e

Browse files
tancnlebethesque
authored andcommitted
fix: version column resize when clipboard icon appears (pact-foundation#292)
Use invisibility style to preserve clipboard icon space
1 parent e173f5c commit 5aa668e

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

lib/pact_broker/ui/views/index/show-with-tags.haml

+2-2
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
%td.consumer-version-number
4242
%div.clippable
4343
= escape_html(index_item.consumer_version_number)
44-
%button.clippy.hidden{ title: "Copy to clipboard" }
44+
%button.clippy.invisible{ title: "Copy to clipboard" }
4545
%span.glyphicon.glyphicon-copy
4646
- if index_item.latest?
4747
.tag.label.label-success
@@ -60,7 +60,7 @@
6060
%td.provider-version-number
6161
%div.clippable
6262
= escape_html(index_item.provider_version_number)
63-
%button.clippy.hidden{ title: "Copy to clipboard" }
63+
%button.clippy.invisible{ title: "Copy to clipboard" }
6464
%span.glyphicon.glyphicon-copy
6565
- index_item.provider_version_latest_tag_names.each do | tag_name |
6666
.tag.label.label-primary

lib/pact_broker/ui/views/matrix/show.haml

+2-2
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@
106106
%div.clippable
107107
%a{href: line.consumer_version_number_url}
108108
= line.display_consumer_version_number
109-
%button.clippy.hidden{ title: "Copy to clipboard" }
109+
%button.clippy.invisible{ title: "Copy to clipboard" }
110110
%span.glyphicon.glyphicon-copy
111111
- line.latest_consumer_version_tags.each do | tag |
112112
.tag-parent{"title": tag.tooltip, "data-toggle": "tooltip", "data-placement": "right"}
@@ -132,7 +132,7 @@
132132
%div.clippable
133133
%a{href: line.provider_version_number_url}
134134
= line.display_provider_version_number
135-
%button.clippy.hidden{ title: "Copy to clipboard" }
135+
%button.clippy.invisible{ title: "Copy to clipboard" }
136136
%span.glyphicon.glyphicon-copy
137137
- line.latest_provider_version_tags.each do | tag |
138138
.tag-parent{"title": tag.tooltip, "data-toggle": "tooltip", "data-placement": "right"}

public/javascripts/clipboard.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* @example in Haml
55
* %div.clippable
66
* = Text to be copied
7-
* %button.clippy.hidden{ title: "Copy to clipboard" }
7+
* %button.clippy.invisible{ title: "Copy to clipboard" }
88
* %span.glyphicon.glyphicon-copy
99
*/
1010

@@ -17,7 +17,7 @@ function initializeClipper(selector) {
1717
const elements = $(selector);
1818

1919
elements.hover(function() {
20-
$(this).children(".clippy").toggleClass("hidden");
20+
$(this).children(".clippy").toggleClass("invisible");
2121
});
2222

2323
elements

0 commit comments

Comments
 (0)