feat(webhooks): do not redact a password with a parameter in it

Author: bethesque

lib/pact_broker/webhooks/webhook_request_template.rb

@@ -48,7 +48,7 @@ def description
       end
 
       def display_password
-        password.nil? ? nil : "**********"
+        password.nil? ? nil : (PactBroker::Webhooks::Render.includes_parameter?(password) ? password : "**********")
       end
 
       def redacted_headers

spec/lib/pact_broker/webhooks/webhook_request_template_spec.rb

@@ -8,7 +8,7 @@ module Webhooks
           method: 'POST',
           url: url,
           username: "username",
-          password: "password",
+          password: password,
           uuid: "1234",
           body: body,
           headers: headers
@@ -27,6 +27,7 @@ module Webhooks
         }
       end
 
+      let(:password) { "password" }
       let(:headers) { {'headername' => 'headervalue'} }
       let(:url) { "http://example.org/hook?foo=bar" }
       let(:base_url) { "http://broker" }
@@ -156,6 +157,28 @@ module Webhooks
           end
         end
       end
+
+      describe "display_password" do
+        subject { WebhookRequestTemplate.new(attributes) }
+
+        context "when it is nil" do
+          let(:password) { nil }
+
+          its(:display_password) { is_expected.to be nil }
+        end
+
+        context "when the password contains a parameter" do
+          let(:password) { "${pactbroker.foo}" }
+
+          its(:display_password) { is_expected.to eq password }
+        end
+
+        context "when the password does not contains a parameter" do
+          let(:password) { "foo" }
+
+          its(:display_password) { is_expected.to eq "**********" }
+        end
+      end
     end
   end
 end