fix: raise PactBroker::Error when either pacticipant is not found in the business layer while attempting to delete an integration

Author: bethesque

lib/pact_broker/integrations/service.rb

@@ -31,8 +31,8 @@ def self.find_all
       end
 
       def self.delete(consumer_name, provider_name)
-        consumer = pacticipant_service.find_pacticipant_by_name(consumer_name)
-        provider = pacticipant_service.find_pacticipant_by_name(provider_name)
+        consumer = pacticipant_service.find_pacticipant_by_name!(consumer_name)
+        provider = pacticipant_service.find_pacticipant_by_name!(provider_name)
         # this takes care of the triggered webhooks and webhook executions
         pact_service.delete_all_pact_publications_between(consumer_name, and: provider_name)
         verification_service.delete_all_verifications_between(consumer_name, and: provider_name)

lib/pact_broker/pacts/repository.rb

@@ -107,8 +107,8 @@ def find_all_pact_versions_between consumer_name, options
       end
 
       def delete_all_pact_publications_between consumer_name, options
-        consumer = pacticipant_repository.find_by_name(consumer_name)
-        provider = pacticipant_repository.find_by_name(options.fetch(:and))
+        consumer = pacticipant_repository.find_by_name!(consumer_name)
+        provider = pacticipant_repository.find_by_name!(options.fetch(:and))
         query = PactPublication.where(consumer: consumer, provider: provider)
         query = query.tag(options[:tag]) if options[:tag]
 

lib/pact_broker/verifications/repository.rb

@@ -136,8 +136,8 @@ def delete_by_provider_version_id version_id
       end
 
       def delete_all_verifications_between(consumer_name, options)
-        consumer = pacticipant_repository.find_by_name(consumer_name)
-        provider = pacticipant_repository.find_by_name(options.fetch(:and))
+        consumer = pacticipant_repository.find_by_name!(consumer_name)
+        provider = pacticipant_repository.find_by_name!(options.fetch(:and))
         PactBroker::Domain::Verification.where(provider: provider, consumer: consumer).delete
       end
 

spec/features/delete_integration_spec.rb

@@ -1,4 +1,4 @@
-describe "Deleting pact versions" do
+describe "Deleting an integration" do
 
   let(:path) { "/integrations/provider/Bar/consumer/Foo" }
 
@@ -19,7 +19,7 @@
     end
   end
 
-  context "when the pact does not exist" do
+  context "when the integration does not exist" do
     it "returns a 404 Not Found" do
       expect(subject.status).to be 404
     end

spec/lib/pact_broker/integrations/service_spec.rb

@@ -248,6 +248,12 @@ module Integrations
             Service.delete("Foo", "Foo")
           end
         end
+
+        context "when the pacticipants are not found for some bizarre reason (I can't see how this can happen, but it has)" do
+          it "raises an error" do
+            expect { Service.delete("Foo", "Bar") }.to raise_error(PactBroker::Error, /found/)
+          end
+        end
       end
 
       describe "delete_all" do