fix: show consumer/provider/global webhooks in webhook column on index page

Fixes: pact-foundation#234

Author: bethesque

lib/pact_broker/matrix/head_row.rb

@@ -1,4 +1,5 @@
 require 'pact_broker/matrix/row'
+require 'pact_broker/webhooks/webhook'
 
 module PactBroker
   module Matrix
@@ -29,6 +30,25 @@ class HeadRow < Row
           end
         end
       end)
+
+      # When viewing the index, every webhook in the database will match at least one of the rows, so
+      # it makes sense to load the entire table and match each webhook to the appropriate row.
+      # This will only work when using eager loading. The keys are just blanked out to avoid errors.
+      # I don't understand how they work at all.
+      # It would be nice to do this declaratively.
+      many_to_many :webhooks, :left_key => [], left_primary_key: [], :eager_loader=>(proc do |eo_opts|
+        eo_opts[:rows].each do |row|
+          row.associations[:webhooks] = []
+        end
+
+        PactBroker::Webhooks::Webhook.each do | webhook |
+          eo_opts[:rows].each do | row |
+            if webhook.is_for?(row)
+              row.associations[:webhooks] << webhook
+            end
+          end
+        end
+      end)
     end
   end
 end

lib/pact_broker/matrix/row.rb

@@ -14,7 +14,6 @@ class Row < Sequel::Model(:matrix)
       TP_COLS = [ :consumer_version_number, :pact_revision_number, :provider_version_number, :verification_number]
 
       associate(:one_to_many, :latest_triggered_webhooks, :class => "PactBroker::Webhooks::LatestTriggeredWebhook", primary_key: :pact_publication_id, key: :pact_publication_id)
-      associate(:one_to_many, :webhooks, :class => "PactBroker::Webhooks::Webhook", primary_key: [:consumer_id, :provider_id], key: [:consumer_id, :provider_id])
       associate(:one_to_many, :consumer_version_tags, :class => "PactBroker::Tags::TagWithLatestFlag", primary_key: :consumer_version_id, key: :version_id)
       associate(:one_to_many, :provider_version_tags, :class => "PactBroker::Tags::TagWithLatestFlag", primary_key: :provider_version_id, key: :version_id)
 

lib/pact_broker/webhooks/webhook.rb

@@ -71,6 +71,10 @@ def parsed_body
         end
       end
 
+      def is_for? relationship
+        (consumer_id == relationship.consumer_id || !consumer_id) && (provider_id == relationship.provider_id || !provider_id)
+      end
+
       private
 
       def self.properties_hash_from_domain webhook

spec/lib/pact_broker/matrix/head_row_spec.rb

@@ -5,6 +5,29 @@ module Matrix
     describe HeadRow do
       let(:td) { TestDataBuilder.new }
 
+      describe "webhooks" do
+        let(:td) { TestDataBuilder.new }
+
+        before do
+          td.create_consumer("Foo")
+            .create_provider("Bar")
+            .create_consumer_version
+            .create_pact
+            .create_global_webhook
+            .create_consumer_webhook
+            .create_provider_webhook
+            .create_provider("Wiffle")
+            .create_provider_webhook
+        end
+
+        let(:row) { HeadRow.where(consumer_name: "Foo", provider_name: "Bar").single_record }
+
+        it "returns all the webhooks" do
+          rows = HeadRow.eager(:webhooks).all
+          expect(rows.first.webhooks.count).to eq 3
+        end
+      end
+
       describe "latest_verification_for_consumer_version_tag" do
         context "when the pact with a given tag has been verified" do
           before do

spec/lib/pact_broker/webhooks/webhook_spec.rb

@@ -0,0 +1,39 @@
+require 'pact_broker/webhooks/webhook'
+
+module PactBroker
+  module Webhooks
+    describe Webhook do
+
+      let(:td) { TestDataBuilder.new }
+
+      before do
+        td.create_consumer("Foo")
+          .create_provider("Bar")
+          .create_consumer_version
+          .create_pact
+          .create_global_webhook
+          .create_consumer_webhook
+          .create_provider_webhook
+          .create_provider("Wiffle")
+          .create_provider_webhook
+      end
+
+      let(:consumer) { PactBroker::Domain::Pacticipant.find(name: "Foo") }
+      let(:provider) { PactBroker::Domain::Pacticipant.find(name: "Bar") }
+      let(:pact) { double(consumer_id: consumer.id, provider_id: provider.id).as_null_object }
+
+      describe "#is_for?" do
+        let(:matching_webhook_uuids) { Webhooks::Repository.new.find_by_consumer_and_or_provider(consumer, provider).collect(&:uuid) }
+        let(:matching_webhooks) { Webhooks::Webhook.where(uuid: matching_webhook_uuids) }
+        let(:non_matching_webhooks) { Webhooks::Webhook.exclude(uuid: matching_webhook_uuids) }
+
+        it "matches the implementation of Webhook::Repository#find_by_consumer_and_or_provider" do
+          expect(matching_webhooks.count).to be > 0
+          expect(non_matching_webhooks.count).to be > 0
+          expect(matching_webhooks.all?{|w| w.is_for?(pact)}).to be true
+          expect(non_matching_webhooks.all?{|w| !w.is_for?(pact)}).to be true
+        end
+      end
+    end
+  end
+end