feat(tagged-pact-versions): ensure triggered webhooks are deleted when pact versions are deleted

Author: bethesque

lib/pact_broker/pacts/repository.rb

@@ -83,6 +83,7 @@ def find_all_pact_versions_between consumer_name, options
 
       def delete_all_pact_versions_between consumer_name, options
         ids = find_all_database_versions_between(consumer_name, options).select_for_subquery(:id)
+        webhook_repository.delete_triggered_webhooks_by_pact_publication_ids(ids)
         PactPublication.where(id: ids).delete
       end
 

spec/features/delete_tagged_pact_versions_spec.rb

@@ -0,0 +1,28 @@
+describe "Deleting tagged pact versions" do
+
+  let(:path) { "/pacts/provider/Bar/consumer/Foo/tag/prod" }
+
+  subject { delete(path)  }
+
+  context "when the pact exists" do
+    before do
+      TestDataBuilder.new
+        .create_pact_with_hierarchy("Foo", "1.2.3", "Bar")
+        .create_consumer_version_tag("prod")
+    end
+
+    it "deletes the pact" do
+      expect{ subject }.to change{ PactBroker::Pacts::PactPublication.count }.by(-1)
+    end
+
+    it "returns a 204" do
+      expect(subject.status).to be 204
+    end
+  end
+
+  context "when the pact does not exist" do
+    it "returns a 404 Not Found" do
+      expect(subject.status).to be 404
+    end
+  end
+end

spec/lib/pact_broker/pacts/repository_spec.rb

@@ -305,6 +305,9 @@ module Pacts
             .create_consumer_version("1.2.3")
             .create_provider(provider_name)
             .create_pact
+            .create_webhook
+            .create_triggered_webhook
+            .create_webhook_execution
             .create_consumer_version("2.3.4")
             .create_consumer_version_tag("prod")
             .create_consumer_version_tag("branch")