Skip to content

Commit 0ae529d

Browse files
committed
BugFix: Triggering deprecation warnings in error-log causes system failures because of changing the behavior in error reporting (#76)
1 parent d6c7a28 commit 0ae529d

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

Net/SMTP.php

+6
Original file line numberDiff line numberDiff line change
@@ -835,8 +835,10 @@ public function setAuthMethod($name, $callback, $prepend = true)
835835
*/
836836
protected function authDigestMD5($uid, $pwd, $authz = '')
837837
{
838+
/* TODO trigger deprecation error in 2.0.0 and remove authDigestMD5() in 3.0.0
838839
trigger_error(__CLASS__ . ' (' . $this->host . '): Authentication method DIGEST-MD5' .
839840
' is no longer secure and should be avoided.', E_USER_DEPRECATED);
841+
*/
840842

841843
if (PEAR::isError($error = $this->put('AUTH', 'DIGEST-MD5'))) {
842844
return $error;
@@ -890,8 +892,10 @@ protected function authDigestMD5($uid, $pwd, $authz = '')
890892
*/
891893
protected function authCRAMMD5($uid, $pwd, $authz = '')
892894
{
895+
/* TODO trigger deprecation error in 2.0.0 and remove authCRAMMD5() in 3.0.0
893896
trigger_error(__CLASS__ . ' (' . $this->host . '): Authentication method CRAM-MD5' .
894897
' is no longer secure and should be avoided.', E_USER_DEPRECATED);
898+
*/
895899

896900
if (PEAR::isError($error = $this->put('AUTH', 'CRAM-MD5'))) {
897901
return $error;
@@ -933,8 +937,10 @@ protected function authCRAMMD5($uid, $pwd, $authz = '')
933937
*/
934938
protected function authLogin($uid, $pwd, $authz = '')
935939
{
940+
/* TODO trigger deprecation error in 2.0.0 and remove authLogin() in 3.0.0
936941
trigger_error(__CLASS__ . ' (' . $this->host . '): Authentication method LOGIN' .
937942
' is no longer secure and should be avoided.', E_USER_DEPRECATED);
943+
*/
938944

939945
if (PEAR::isError($error = $this->put('AUTH', 'LOGIN'))) {
940946
return $error;

package.xml

+3-8
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@
2222
<email>schengawegga@gmail.com</email>
2323
<active>yes</active>
2424
</lead>
25-
<date>2023-10-26</date>
25+
<date>2023-11-01</date>
2626
<version>
27-
<release>1.11.0</release>
27+
<release>1.11.1</release>
2828
<api>1.4.0</api>
2929
</version>
3030
<stability>
@@ -33,12 +33,7 @@
3333
</stability>
3434
<license uri="https://opensource.org/licenses/bsd-license.php">BSD-2-Clause</license>
3535
<notes>
36-
* Feature: Add SCRAM-SHA-1, SCRAM-SHA-224, SCRAM-SHA-256, SCRAM-SHA-384 and SCRAM-SHA-512 support (#76)
37-
* Task: Mark authentication methods CRAM-MD5, DIGEST-MD5 and LOGIN as DEPRECATED with deprecation warnings in the error-log (#76)
38-
* BugFix: SMTP: STARTTLS failed (code: 220, response: 2.0.0 Ready to start TLS) (#74)
39-
* BugFix: Issue with non-blocking streams on establishing STARTTLS encryption (#74)
40-
* BugFix: Implement TLS1.3 on STARTTLS encryption (#74)
41-
* BugFix: using implode() instead of join() (#74)
36+
* BugFix: Triggering deprecation warnings in error-log causes system failures because of changing the behavior in error reporting (#76)
4237
</notes>
4338
<contents>
4439
<dir baseinstalldir="/" name="/">

0 commit comments

Comments
 (0)