Skip to content

Commit 358da75

Browse files
committed
chore(deps): update to java17 / springboot3
1 parent dbde2d3 commit 358da75

File tree

9 files changed

+40
-52
lines changed

9 files changed

+40
-52
lines changed

.github/workflows/build.yml

+6-6
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@ jobs:
1515
test:
1616
runs-on: ubuntu-latest
1717
steps:
18-
- uses: actions/checkout@v2
19-
- name: Set up JDK 11
20-
uses: actions/setup-java@v2
18+
- uses: actions/checkout@v4
19+
- name: Set up JDK 17
20+
uses: actions/setup-java@v4
2121
with:
2222
distribution: 'zulu'
23-
java-version: '11'
23+
java-version: '17'
2424
- name: Test
2525
run: GIT_BRANCH=${GITHUB_REF:11} make ci
2626

@@ -29,7 +29,7 @@ jobs:
2929
runs-on: ubuntu-latest
3030
needs: test
3131
steps:
32-
- uses: actions/checkout@v2
32+
- uses: actions/checkout@v4
3333
- run: docker pull pactfoundation/pact-cli:latest
3434
- name: Can I deploy?
3535
run: GIT_BRANCH=${GITHUB_REF:11} make can_i_deploy
@@ -39,7 +39,7 @@ jobs:
3939
runs-on: ubuntu-latest
4040
needs: can-i-deploy
4141
steps:
42-
- uses: actions/checkout@v2
42+
- uses: actions/checkout@v4
4343
- run: docker pull pactfoundation/pact-cli:latest
4444
- name: Deploy
4545
run: GIT_BRANCH=${GITHUB_REF:11} make deploy

.java-version

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
11
1+
17.0

build.gradle

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
plugins {
2-
id 'org.springframework.boot' version '2.2.2.RELEASE'
3-
id 'io.spring.dependency-management' version '1.0.8.RELEASE'
2+
id 'org.springframework.boot' version '3.3.4'
3+
id 'io.spring.dependency-management' version '1.1.6'
44
id 'java'
55
}
66

77
group = 'com.example'
88
version = '0.0.1-SNAPSHOT'
9-
sourceCompatibility = '11'
9+
sourceCompatibility = '17'
1010

1111
repositories {
1212
mavenCentral()
@@ -25,7 +25,7 @@ dependencies {
2525
runtimeOnly 'com.h2database:h2'
2626
compileOnly 'org.projectlombok:lombok'
2727
annotationProcessor 'org.projectlombok:lombok'
28-
testImplementation 'com.atlassian.oai:swagger-request-validator-restassured:2.18.0'
28+
testImplementation 'com.atlassian.oai:swagger-request-validator-restassured:2.43.0'
2929
testImplementation('org.springframework.boot:spring-boot-starter-test') {
3030
exclude group: 'org.junit.vintage', module: 'junit-vintage-engine'
3131
}

gradle/wrapper/gradle-wrapper.jar

2.96 KB
Binary file not shown.
+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-6.6.1-bin.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-8.10.2-bin.zip
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists

gradlew

+15-17
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
# See the License for the specific language governing permissions and
1616
# limitations under the License.
1717
#
18+
1819
##############################################################################
1920
##
2021
## Gradle start up script for UN*X
@@ -81,6 +82,7 @@ esac
8182

8283
CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar
8384

85+
8486
# Determine the Java command to use to start the JVM.
8587
if [ -n "$JAVA_HOME" ] ; then
8688
if [ -x "$JAVA_HOME/jre/sh/java" ] ; then
@@ -128,6 +130,7 @@ fi
128130
if [ "$cygwin" = "true" -o "$msys" = "true" ] ; then
129131
APP_HOME=`cygpath --path --mixed "$APP_HOME"`
130132
CLASSPATH=`cygpath --path --mixed "$CLASSPATH"`
133+
131134
JAVACMD=`cygpath --unix "$JAVACMD"`
132135

133136
# We build the pattern for arguments to be converted via cygpath
@@ -153,19 +156,19 @@ if [ "$cygwin" = "true" -o "$msys" = "true" ] ; then
153156
else
154157
eval `echo args$i`="\"$arg\""
155158
fi
156-
i=$((i+1))
159+
i=`expr $i + 1`
157160
done
158161
case $i in
159-
(0) set -- ;;
160-
(1) set -- "$args0" ;;
161-
(2) set -- "$args0" "$args1" ;;
162-
(3) set -- "$args0" "$args1" "$args2" ;;
163-
(4) set -- "$args0" "$args1" "$args2" "$args3" ;;
164-
(5) set -- "$args0" "$args1" "$args2" "$args3" "$args4" ;;
165-
(6) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" ;;
166-
(7) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" ;;
167-
(8) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" ;;
168-
(9) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" "$args8" ;;
162+
0) set -- ;;
163+
1) set -- "$args0" ;;
164+
2) set -- "$args0" "$args1" ;;
165+
3) set -- "$args0" "$args1" "$args2" ;;
166+
4) set -- "$args0" "$args1" "$args2" "$args3" ;;
167+
5) set -- "$args0" "$args1" "$args2" "$args3" "$args4" ;;
168+
6) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" ;;
169+
7) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" ;;
170+
8) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" ;;
171+
9) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" "$args8" ;;
169172
esac
170173
fi
171174

@@ -174,14 +177,9 @@ save () {
174177
for i do printf %s\\n "$i" | sed "s/'/'\\\\''/g;1s/^/'/;\$s/\$/' \\\\/" ; done
175178
echo " "
176179
}
177-
APP_ARGS=$(save "$@")
180+
APP_ARGS=`save "$@"`
178181

179182
# Collect all arguments for the java command, following the shell quoting and substitution rules
180183
eval set -- $DEFAULT_JVM_OPTS $JAVA_OPTS $GRADLE_OPTS "\"-Dorg.gradle.appname=$APP_BASE_NAME\"" -classpath "\"$CLASSPATH\"" org.gradle.wrapper.GradleWrapperMain "$APP_ARGS"
181184

182-
# by default we should be in the correct project dir, but when run from Finder on Mac, the cwd is wrong
183-
if [ "$(uname)" = "Darwin" ] && [ "$HOME" = "$PWD" ]; then
184-
cd "$(dirname "$0")"
185-
fi
186-
187185
exec "$JAVACMD" "$@"

gradlew.bat

+7-18
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@ if "%DIRNAME%" == "" set DIRNAME=.
2929
set APP_BASE_NAME=%~n0
3030
set APP_HOME=%DIRNAME%
3131

32+
@rem Resolve any "." and ".." in APP_HOME to make it shorter.
33+
for %%i in ("%APP_HOME%") do set APP_HOME=%%~fi
34+
3235
@rem Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
3336
set DEFAULT_JVM_OPTS="-Xmx64m" "-Xms64m"
3437

@@ -37,7 +40,7 @@ if defined JAVA_HOME goto findJavaFromJavaHome
3740

3841
set JAVA_EXE=java.exe
3942
%JAVA_EXE% -version >NUL 2>&1
40-
if "%ERRORLEVEL%" == "0" goto init
43+
if "%ERRORLEVEL%" == "0" goto execute
4144

4245
echo.
4346
echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH.
@@ -51,7 +54,7 @@ goto fail
5154
set JAVA_HOME=%JAVA_HOME:"=%
5255
set JAVA_EXE=%JAVA_HOME%/bin/java.exe
5356

54-
if exist "%JAVA_EXE%" goto init
57+
if exist "%JAVA_EXE%" goto execute
5558

5659
echo.
5760
echo ERROR: JAVA_HOME is set to an invalid directory: %JAVA_HOME%
@@ -61,28 +64,14 @@ echo location of your Java installation.
6164

6265
goto fail
6366

64-
:init
65-
@rem Get command-line arguments, handling Windows variants
66-
67-
if not "%OS%" == "Windows_NT" goto win9xME_args
68-
69-
:win9xME_args
70-
@rem Slurp the command line arguments.
71-
set CMD_LINE_ARGS=
72-
set _SKIP=2
73-
74-
:win9xME_args_slurp
75-
if "x%~1" == "x" goto execute
76-
77-
set CMD_LINE_ARGS=%*
78-
7967
:execute
8068
@rem Setup the command line
8169

8270
set CLASSPATH=%APP_HOME%\gradle\wrapper\gradle-wrapper.jar
8371

72+
8473
@rem Execute Gradle
85-
"%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" org.gradle.wrapper.GradleWrapperMain %CMD_LINE_ARGS%
74+
"%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" org.gradle.wrapper.GradleWrapperMain %*
8675

8776
:end
8877
@rem End local scope for the variables with windows NT shell

src/main/java/com/example/springboot/Product.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22

33
import lombok.Data;
44

5-
import javax.persistence.Entity;
6-
import javax.persistence.Id;
5+
import jakarta.persistence.Entity;
6+
import jakarta.persistence.Id;
77

88
import com.fasterxml.jackson.annotation.JsonFormat;
99

src/test/java/com/example/springboot/ProductsAPITest.java

+4-3
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import org.junit.jupiter.api.extension.ExtendWith;
77
import org.springframework.beans.factory.annotation.Autowired;
88
import org.springframework.boot.test.context.SpringBootTest;
9-
import org.springframework.boot.web.server.LocalServerPort;
9+
import org.springframework.boot.test.web.server.LocalServerPort;
1010
import org.springframework.test.context.junit.jupiter.SpringExtension;
1111

1212
import com.atlassian.oai.validator.OpenApiInteractionValidator;
@@ -38,6 +38,7 @@ class ProductsAPITest {
3838
.build();
3939

4040
// Use this for "negative scenario" testing
41+
// ref: https://bitbucket.org/atlassian/swagger-request-validator/issues/332/restassured-skip-request-validation-with
4142
private OpenApiValidationFilter responseOnlyValidation = new OpenApiValidationFilter(responseOnlyValidator);
4243

4344
@Test
@@ -66,11 +67,11 @@ public void testGetProduct200() {
6667

6768
@Test
6869
public void testGetProduct404() {
69-
given().port(port).filter(validationFilter).when().get("/product/999").then().assertThat().statusCode(404);
70+
given().port(port).filter(responseOnlyValidation).when().get("/product/999").then().assertThat().statusCode(404);
7071
}
7172

7273
@Test
7374
public void testGetProduct400() {
74-
given().port(port).filter(validationFilter).when().get("/product/notanumber").then().assertThat().statusCode(400);
75+
given().port(port).filter(responseOnlyValidation).when().get("/product/notanumber").then().assertThat().statusCode(400);
7576
}
7677
}

0 commit comments

Comments
 (0)