fix: require pact_specification_version when spawning mock service through app manager

Author: bethesque

lib/pact/mock_service/app_manager.rb

@@ -30,7 +30,7 @@ def register_mock_service_for(name, url, options = {})
           name: name,
           log_file: create_log_file(name),
           pact_dir: pact_dir,
-          pact_specification_version: options[:pact_specification_version]
+          pact_specification_version: options.fetch(:pact_specification_version)
         )
         register(app, uri.port)
       end

spec/lib/pact/mock_service/app_manager_spec.rb

@@ -12,18 +12,19 @@ module Pact::MockService
       end
 
       let(:name) { 'some_service'}
+      let(:options) { { pact_specification_version: '3' } }
 
       context "for http://localhost" do
         let(:url) { 'http://localhost:1234'}
 
         it "starts a mock service at the given port on localhost" do
           expect_any_instance_of(AppRegistration).to receive(:spawn)
-          AppManager.instance.register_mock_service_for name, url
+          AppManager.instance.register_mock_service_for name, url, options
           AppManager.instance.spawn_all
         end
 
         it "registers the mock service as running on the given port" do
-          AppManager.instance.register_mock_service_for name, url
+          AppManager.instance.register_mock_service_for name, url, options
           expect(AppManager.instance.app_registered_on?(1234)).to eq true
         end
 
@@ -32,37 +33,41 @@ module Pact::MockService
           expect(Pact::MockService).to receive(:new) do | options |
             expect(options[:pact_dir]).to eq 'pact_dir'
           end
-          AppManager.instance.register_mock_service_for name, url
+          AppManager.instance.register_mock_service_for name, url, options
         end
 
         it "passes in the pact_specification_verson to the MockService" do
           expect(Pact::MockService).to receive(:new).with(hash_including(pact_specification_version: '3')).and_call_original
-          AppManager.instance.register_mock_service_for name, url, pact_specification_version: '3'
+          AppManager.instance.register_mock_service_for name, url, options
         end
       end
 
       context "for https://" do
         let(:url) { 'https://localhost:1234'}
 
         it "should throw an unsupported error" do
-          expect { AppManager.instance.register_mock_service_for name, url }.to raise_error "Currently only http is supported"
+          expect { AppManager.instance.register_mock_service_for name, url, options }.to raise_error "Currently only http is supported"
         end
       end
 
       context "for a host other than localhost" do
         let(:url) { 'http://aserver:1234'}
 
         it "should throw an unsupported error" do
-          expect { AppManager.instance.register_mock_service_for name, url }.to raise_error "Currently only services on localhost are supported"
+          expect { AppManager.instance.register_mock_service_for name, url, options }.to raise_error "Currently only services on localhost are supported"
         end
       end
 
       describe "find_a_port option" do
         let(:url) { 'http://localhost' }
 
+        before do
+          options[:find_available_port] = true
+        end
+
         it "builds AppRegistration with `nil` port" do
           expect(AppRegistration).to receive(:new).with(hash_including(port: nil)).and_call_original
-          AppManager.instance.register_mock_service_for name, url, find_available_port: true
+          AppManager.instance.register_mock_service_for name, url, options
         end
       end
     end