Skip to content

Commit b00dd98

Browse files
committed
Always set 'Access-Control-Allow-Credentials: true' in preflight response
1 parent 9e3f3a8 commit b00dd98

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

lib/pact/mock_service/request_handlers/options.rb

+2
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ class Options < BaseRequestHandler
99

1010
HTTP_ACCESS_CONTROL_REQUEST_METHOD = "HTTP_ACCESS_CONTROL_REQUEST_METHOD".freeze
1111
HTTP_ACCESS_CONTROL_REQUEST_HEADERS = "HTTP_ACCESS_CONTROL_REQUEST_HEADERS".freeze
12+
ACCESS_CONTROL_ALLOW_CREDENTIALS = "Access-Control-Allow-Credentials".freeze
1213
ACCESS_CONTROL_ALLOW_ORIGIN = "Access-Control-Allow-Origin".freeze
1314
ACCESS_CONTROL_ALLOW_METHODS = "Access-Control-Allow-Methods".freeze
1415
ACCESS_CONTROL_ALLOW_HEADERS = "Access-Control-Allow-Headers".freeze
@@ -30,6 +31,7 @@ def match? env
3031

3132
def respond env
3233
cors_headers = {
34+
ACCESS_CONTROL_ALLOW_CREDENTIALS => 'true',
3335
ACCESS_CONTROL_ALLOW_ORIGIN => env.fetch(HTTP_ORIGIN,'*'),
3436
ACCESS_CONTROL_ALLOW_HEADERS => env.fetch(HTTP_ACCESS_CONTROL_REQUEST_HEADERS, '*'),
3537
ACCESS_CONTROL_ALLOW_METHODS => ALL_METHODS

spec/lib/pact/mock_service/request_handlers/options_spec.rb

+1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ module RequestHandlers
2323
subject { response[1] }
2424

2525
it { is_expected.to include 'Access-Control-Allow-Methods' => 'DELETE, POST, GET, HEAD, PUT, TRACE, CONNECT, PATCH' }
26+
it { is_expected.to include 'Access-Control-Allow-Credentials' => 'true' }
2627

2728
context "with Origin" do
2829
it { is_expected.to include 'Access-Control-Allow-Origin' => 'foo.com' }

0 commit comments

Comments
 (0)