Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull GitHub comments from our own API #31

Open
benjaminleonard opened this issue Jan 23, 2023 · 0 comments
Open

Pull GitHub comments from our own API #31

benjaminleonard opened this issue Jan 23, 2023 · 0 comments

Comments

@benjaminleonard
Copy link
Collaborator

Through CIO, or it's own runner, we should mirror the comments from the GitHub API perhaps also moving the logic that rearranges them into threads there too.

Currently RFD 4 (with 248 comments) can take 15s+ to retrieve. Response times increase based on the number of comments, but we can't just get the first page. We want all of the inline comments visible, but currently we have to request them all, outdated or not.

Simply moving this to it's own API would speed this up massively, but we can likely optimise it further with a paginated API for the full list of comments, and only returning the count and inline comments on page load.

@benjaminleonard benjaminleonard transferred this issue from another repository Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant