Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: want better Hyper-V overlay page management #850

Closed
gjcolombo opened this issue Feb 6, 2025 · 0 comments · Fixed by #861
Closed

lib: want better Hyper-V overlay page management #850

gjcolombo opened this issue Feb 6, 2025 · 0 comments · Fixed by #861
Assignees

Comments

@gjcolombo
Copy link
Contributor

#849 takes a very cavalier approach to Hyper-V overlay pages; in particular it does not ensure that a guest physical page's original contents are restored when all overlays are removed. This breaks the semantics described in section 5.2.1 of the Hyper-V TLFS.

The only overlay used in #849 is the hypercall page overlay, and empirically, most guest OSes seem not to care about disabling or relocating this page once they've established it. Nevertheless, Propolis should follow the TLFS's rules for these pages.

Needed for #328.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant