various new 1.85 clippy lints

the packed structs almost certainly should be repr(C) (why does that
default to repr(Rust)???)

the indentation change is unfortunate and doc_overindented_list_items
hasn't really convinced me that this *would* introduce broken spacing in
rendered docs, but i don't have it in me to allow the lint for a few
lines like this.

Author: iximeow

bin/propolis-server/src/lib/stats/mod.rs

@@ -134,12 +134,12 @@ impl Producer for ServerStats {
 ///
 /// - `id`: The ID of the instance for whom this server is being started.
 /// - `config`: The metrics config options, including our address (on which we
-///    serve metrics for oximeter to collect), and the registration address (a
-///    Nexus instance through which we request registration as an oximeter
-///    producer).
+///   serve metrics for oximeter to collect), and the registration address (a
+///   Nexus instance through which we request registration as an oximeter
+///   producer).
 /// - `log`: A logger to use when logging from this routine.
 /// - `registry`: The oximeter [`ProducerRegistry`] that the spawned server will
-///    use to return metric data to oximeter on request.
+///   use to return metric data to oximeter on request.
 ///
 /// The returned server will attempt to register with Nexus in a background
 /// task, and will periodically renew that registration. The returned server is

crates/rfb/src/proto.rs

@@ -637,7 +637,7 @@ mod raw {
 
     #[allow(dead_code)]
     #[derive(Copy, Clone, FromBytes, FromZeroes, AsBytes)]
-    #[repr(packed)]
+    #[repr(C, packed)]
     pub(crate) struct PixelFormat {
         pub bits_per_pixel: u8,
         pub depth: u8,
@@ -653,30 +653,30 @@ mod raw {
     }
 
     #[derive(Copy, Clone, FromBytes, FromZeroes)]
-    #[repr(packed)]
+    #[repr(C, packed)]
     pub(crate) struct FramebufferUpdateRequest {
         pub incremental: u8,
         pub position: Position,
         pub resolution: Resolution,
     }
 
     #[derive(Copy, Clone, FromBytes, FromZeroes)]
-    #[repr(packed)]
+    #[repr(C, packed)]
     pub(crate) struct KeyEvent {
         pub down_flag: u8,
         pub _padding: [u8; 2],
         pub key: U32,
     }
 
     #[derive(Copy, Clone, FromBytes, FromZeroes)]
-    #[repr(packed)]
+    #[repr(C, packed)]
     pub(crate) struct PointerEvent {
         pub button_mask: u8,
         pub position: Position,
     }
 
     #[derive(Copy, Clone, FromBytes, FromZeroes)]
-    #[repr(packed)]
+    #[repr(C, packed)]
     pub(crate) struct Position {
         pub x: U16,
         pub y: U16,
@@ -688,7 +688,7 @@ mod raw {
     }
 
     #[derive(Copy, Clone, FromBytes, FromZeroes)]
-    #[repr(packed)]
+    #[repr(C, packed)]
     pub(crate) struct Resolution {
         width: U16,
         height: U16,
@@ -700,7 +700,7 @@ mod raw {
     }
 
     #[derive(Copy, Clone, AsBytes)]
-    #[repr(packed)]
+    #[repr(C, packed)]
     #[allow(dead_code)]
     pub(crate) struct FramebufferUpdateHeader {
         msg_type: u8,

lib/propolis/src/vmm/mem.rs

@@ -1061,7 +1061,7 @@ impl<T: Copy + FromBytes> Iterator for GuestData<MemMany<'_, T>> {
     fn next(&mut self) -> Option<Self::Item> {
         let res = self.get(self.pos);
         self.pos += 1;
-        res.map(GuestData::from)
+        res
     }
 }
 

xtask/src/task_phd.rs

@@ -303,7 +303,6 @@ impl Cmd {
 
         let artifact_dir = artifact_args
             .artifact_directory
-            .map(Utf8PathBuf::from)
             .unwrap_or_else(|| {
                 // if there's no explicitly overridden `artifact_dir` path, use
                 // `target/phd/artifacts`.
@@ -334,7 +333,6 @@ impl Cmd {
 
         let artifacts_toml = artifact_args
             .artifact_toml_path
-            .map(Utf8PathBuf::from)
             .unwrap_or_else(|| {
                 // if there's no explicitly overridden `artifacts.toml` path,
                 // determine the default one from the workspace path.