-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to set error response headers #801
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I currently have response headers working for CORS, after looking at how Oxide does so in
cio
: https://github.com/bencherdev/bencher/blob/main/services/api/src/util/headers.rsI think this may solve: #57
But there is no way to set error response headers.
The headers for a valid request look like this (happy CORS):
But the headers for an error request look like this (unhappy CORS):
Internally, it looks like
dropshot
uses thisHttpError
into_response
method: https://docs.rs/dropshot/latest/src/dropshot/error.rs.html#237So it would be great to be able to add additional headers to
HttpError
or just have it also use the headers set for a valid request.The text was updated successfully, but these errors were encountered: