Skip to content

Commit 662b84e

Browse files
leftwoAlan Hanson
and
Alan Hanson
authored
Deactivate the read only parent after a scrub (#1180)
If the scrub on a read only parent finishes without error, then send a deactivate to force a disconnect from all the downstairs. Co-authored-by: Alan Hanson <alan@oxide.computer>
1 parent bf25e38 commit 662b84e

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

upstairs/src/volume.rs

+7
Original file line numberDiff line numberDiff line change
@@ -445,6 +445,13 @@ impl Volume {
445445
pause_millis,
446446
);
447447
self.flush(None).await?;
448+
info!(self.log, "Deactivate read only parent {}", self.uuid,);
449+
if let Err(e) = read_only_parent.deactivate().await {
450+
warn!(
451+
self.log,
452+
"deactivate ROP on {} failed with {}", self.uuid, e
453+
);
454+
}
448455
} else {
449456
info!(self.log, "Scrub for {} not required", self.uuid);
450457
}

0 commit comments

Comments
 (0)