Remove individual panic setup, use global panic settings (#1174)

Author: leftwo

agent/src/main.rs

@@ -234,16 +234,6 @@ impl ZFSDataset {
 
 #[tokio::main]
 async fn main() -> Result<()> {
-    /*
-     * If any of our async tasks in our runtime panic, then we should exit
-     * the program right away.
-     */
-    let default_panic = std::panic::take_hook();
-    std::panic::set_hook(Box::new(move |info| {
-        default_panic(info);
-        std::process::exit(1);
-    }));
-
     let args = Args::try_parse()?;
 
     match args {

crutest/src/main.rs

@@ -595,16 +595,6 @@ async fn handle_signals(
  */
 #[tokio::main]
 async fn main() -> Result<()> {
-    /*
-     * If any of our async tasks in our runtime panic, then we should
-     * exit the program right away.
-     */
-    let default_panic = std::panic::take_hook();
-    std::panic::set_hook(Box::new(move |info| {
-        default_panic(info);
-        std::process::exit(1);
-    }));
-
     let opt = opts()?;
 
     // If we just want the version, print that and exit.

downstairs/src/main.rs

@@ -376,16 +376,6 @@ async fn main() -> Result<()> {
             root_cert_pem,
             mode,
         } => {
-            /*
-             * If any of our async tasks in our runtime panic, then we should
-             * exit the program right away.
-             */
-            let default_panic = std::panic::take_hook();
-            std::panic::set_hook(Box::new(move |info| {
-                default_panic(info);
-                std::process::exit(1);
-            }));
-
             // Instrumentation is shared.
             if let Some(endpoint) = trace_endpoint {
                 let tracer = opentelemetry_jaeger::new_agent_pipeline()
@@ -435,16 +425,6 @@ async fn main() -> Result<()> {
             trace_endpoint,
             bind_addr,
         } => {
-            /*
-             * If any of our async tasks in our runtime panic, then we should
-             * exit the program right away.
-             */
-            let default_panic = std::panic::take_hook();
-            std::panic::set_hook(Box::new(move |info| {
-                default_panic(info);
-                std::process::exit(1);
-            }));
-
             // Instrumentation is shared.
             if let Some(endpoint) = trace_endpoint {
                 let tracer = opentelemetry_jaeger::new_agent_pipeline()

dsc/src/main.rs

@@ -1365,14 +1365,6 @@ fn cleanup(output_dir: PathBuf, region_dir: Vec<PathBuf>) -> Result<()> {
 
 fn main() -> Result<()> {
     let args = Args::parse();
-    // If any of our async tasks in our runtime panic, then we should
-    // exit the program right away.
-    let default_panic = std::panic::take_hook();
-    std::panic::set_hook(Box::new(move |info| {
-        default_panic(info);
-        std::process::exit(1);
-    }));
-
     let runtime = Builder::new_multi_thread()
         .worker_threads(10)
         .thread_name("dsc")

hammer/src/main.rs

@@ -108,16 +108,6 @@ async fn main() -> Result<()> {
         println!("Set up tracing!");
     }
 
-    /*
-     * If any of our async tasks in our runtime panic, then we should
-     * exit the program right away.
-     */
-    let default_panic = std::panic::take_hook();
-    std::panic::set_hook(Box::new(move |info| {
-        default_panic(info);
-        std::process::exit(1);
-    }));
-
     // Create N CruciblePseudoFiles to test activation handoff.
     let mut cpfs: Vec<crucible::CruciblePseudoFile<Guest>> =
         Vec::with_capacity(opt.num_upstairs);

measure_iops/src/main.rs

@@ -91,16 +91,6 @@ async fn main() -> Result<()> {
         read_only: false,
     };
 
-    /*
-     * If any of our async tasks in our runtime panic, then we should
-     * exit the program right away.
-     */
-    let default_panic = std::panic::take_hook();
-    std::panic::set_hook(Box::new(move |info| {
-        default_panic(info);
-        std::process::exit(1);
-    }));
-
     let (guest, mut io) = Guest::new(None);
     let guest = Arc::new(guest);
 

pantry/src/main.rs

@@ -23,16 +23,6 @@ enum Args {
 
 #[tokio::main]
 async fn main() -> Result<()> {
-    /*
-     * If any of our async tasks in our runtime panic, then we should exit
-     * the program right away.
-     */
-    let default_panic = std::panic::take_hook();
-    std::panic::set_hook(Box::new(move |info| {
-        default_panic(info);
-        std::process::exit(1);
-    }));
-
     let args = Args::try_parse()?;
 
     match args {