Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brief introduction on why we connect from R to databases #12

Open
catalamarti opened this issue Jul 23, 2024 · 3 comments
Open

brief introduction on why we connect from R to databases #12

catalamarti opened this issue Jul 23, 2024 · 3 comments
Assignees

Comments

@catalamarti
Copy link
Contributor

catalamarti commented Jul 23, 2024

My comments on the chapter:

  • It might be helpful to include a brief introduction on why we connect from R to databases on a server. This could cover the "database side" and local R, and explain that while the database is in SQL, we work with it in R (a similar introduction to the one usually provided in CDMConnector courses)

  • Overall, the beginning feels too strong, discussing hosts, ports, etc., without much prior context. Adding what I mention in the previous point could make it easier to follow.

  • In the example with the cdm object, consider adding the prefix as it is mentioned in the text.

  • Generally, the vocabulary is plain which I think is really helpful and makes it easier to follow. However, the sentence "this depends on the Database Management System (DBMS) of your back-end" in section 4.4. is too technical without prior explanation of what DBMS and back-end mean.

But overall having this will be really helpful to learn how to connect!!

Originally posted by @nmercadeb in #5 (comment)

@catalamarti catalamarti self-assigned this Jul 23, 2024
@daniellenewby
Copy link
Contributor

Also.. might be useful to have some information on doing it the "old" way (shock horror). As we are having to use the non cdmconnector for studies so might be useful to have this code for reference?

@edward-burn
Copy link
Contributor

@daniellenewby
Copy link
Contributor

I think we can add a link to it in this chapter - it is linked on the preface but maybe add more links to this book throughout?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants