Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mongodb+srv urls with querystring parameters cause the forum to fail #16

Closed
regisb opened this issue Feb 1, 2023 · 2 comments · Fixed by #19
Closed

mongodb+srv urls with querystring parameters cause the forum to fail #16

regisb opened this issue Feb 1, 2023 · 2 comments · Fixed by #19
Assignees
@regisb
Labels
bug Something isn't working

Comments

@regisb
Copy link
Contributor

regisb commented Feb 1, 2023

mongodb+srv urls are introduced in this PR: #10
But querystring parameters will not work in the forum because of the way the MONGOHQ_URLvariable is generated:

MONGOHQ_URL="$MONGODB_HOST/$MONGODB_DATABASE"

We need to modify the definition of MONGOHQ_URL such that querystring parameters are supported. If possible, we should take this opportunity to get rid of the forum entrypoint entirely.
@regisb regisb self-assigned this Feb 1, 2023
@regisb regisb added the bug Something isn't working label Feb 1, 2023
@regisb regisb moved this from Backlog to In Progress in Tutor project management Feb 1, 2023
@regisb regisb changed the title mongodb+src urls with querystring parameters cause the forum to fail mongodb+srv urls with querystring parameters cause the forum to fail Feb 1, 2023
@regisb
Copy link
Contributor Author

regisb commented Feb 1, 2023

@ghassanmas can you please describe how you launched a Mongodb cluster and how you defined the mongodb host url that caused the error you observed?

@ghassanmas
Copy link
Member

1- Generating a cluster through atlass
2- setting the following configuration in tutor config.yml

MONGODB_AUTH_MECHANISM: SCRAM-SHA-1
MONGODB_HOST: mongodb+srv://username:password@x-host.mongodb.net/?retryWrites=true&w=majority
MONGODB_USE_SSL: true
RUN_MONGODB: false

regisb added a commit that referenced this issue Mar 20, 2023
@regisb
fix: don't crash on mongodb host querystring params
34ba3a2 
When the MONGODB_HOST url contained querystring parameters, the forum
was failing because the outdated mongodb gem does not support them. So
we just trim them from the setting.

Close #16.
@regisb regisb mentioned this issue Mar 20, 2023
Merged
@regisb regisb moved this from In Progress to Waiting for review in Tutor project management Mar 20, 2023
regisb added a commit that referenced this issue Mar 21, 2023
@regisb
fix: don't crash on mongodb host querystring params
3721999 
When the MONGODB_HOST url contained querystring parameters, the forum
was failing because the outdated mongodb gem does not support them. So
we just trim them from the setting.

Close #16.
regisb added a commit that referenced this issue Mar 22, 2023
@regisb
fix: don't crash on mongodb host querystring params
20dfb98 
When the MONGODB_HOST url contained querystring parameters, the forum
was failing because the outdated mongodb gem does not support them. So
we just trim them from the setting.

Close #16.
@github-project-automation github-project-automation bot moved this from Waiting for review to Done in Tutor project management Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@regisb regisb

Labels
bug Something isn't working
Projects
Tutor project management
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: don't crash on mongodb host querystring params overhangio/tutor-forum
2 participants
@regisb @ghassanmas