Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScopeDoctorSetup seems to always run even if files haven't changed #60

Closed
technicalpickles opened this issue Feb 7, 2024 · 2 comments
Closed

Comments

@technicalpickles
Copy link
Contributor

Consider:

apiVersion: scope.github.com/v1alpha
kind: ScopeDoctorSetup
metadata:
  name: bundle-update
spec:
  # order: 100 # default value
  cache:
    paths:
      - Gemfile*
      - .ruby-version
  setup:
    exec:
      - bash -c "bundle check >/dev/null || bundle install"
  description: Check for updates to bundled dependencies

I would expect to not have to run this the second time, but I get the same output:

 scope doctor run                                                                                                                                                                        ─╯
 INFO Check initially failed, fix was successful, group: "bundle-update", name: "1"
 INFO Check was successful, group: "03-bundler", name: "1"
 INFO Check was successful, group: "02-ruby-version", name: "1"
 INFO Check was successful, group: "01-rbenv", name: "1"
 INFO Check was successful, group: "00-homebrew", name: "1"
 INFO Check was successful, group: "00-github-ssh", name: "1"
 INFO Check was successful, group: "00-github-cli", name: "1"
 INFO Check was successful, group: "00-aws-sso", name: "1"

I'm not sure how the caching works under the hood, but maybe it's still the same output if it ran previously, as if it ran?

@ethankhall
Copy link
Contributor

Do you have the more verbose output of that run? The caching should say "Check was successful" on the second run.

@technicalpickles
Copy link
Contributor Author

I think #62 has fixed this, plus moving to a doctor group

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants