Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data: fedora 43 repositories #1232

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Conversation

supakeen
Copy link
Member

SSIA.

@supakeen supakeen requested a review from a team as a code owner February 18, 2025 08:42
Copy link
Contributor

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, one tiny idea/suggestion/question

"x86_64": [
{
"name": "fedora",
"metalink": "https://mirrors.fedoraproject.org/metalink?repo=fedora-rawhide&arch=x86_64",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth mentioning in the commit message that we are adding fedora-43 which is currently rawhide? As it is not really labeld fedora-43 in the metalink yet?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It says the following, do you mean you want it in the subject line? :)

data: fedora 43 repositories

These currently refer to rawhide but naming them rawhide is hard in our
stack.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry, I did not see it in the PR description, I have not looked into the individual commit(s). Fine then.

@achilleas-k
Copy link
Member

We should start building these in testing as well. i'll add a snapshot config to rpm repo later.

@achilleas-k
Copy link
Member

Clicking rebase for linter fix and queuing up to merge.

These currently refer to rawhide but naming them rawhide is hard in our
stack.

Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
@achilleas-k achilleas-k added this pull request to the merge queue Feb 18, 2025
Merged via the queue into osbuild:main with commit 1304698 Feb 18, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants