-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data: fedora 43 repositories #1232
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine, one tiny idea/suggestion/question
"x86_64": [ | ||
{ | ||
"name": "fedora", | ||
"metalink": "https://mirrors.fedoraproject.org/metalink?repo=fedora-rawhide&arch=x86_64", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe worth mentioning in the commit message that we are adding fedora-43 which is currently rawhide? As it is not really labeld fedora-43 in the metalink yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It says the following, do you mean you want it in the subject line? :)
data: fedora 43 repositories
These currently refer to rawhide but naming them rawhide is hard in our
stack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry, I did not see it in the PR description, I have not looked into the individual commit(s). Fine then.
We should start building these in testing as well. i'll add a snapshot config to rpm repo later. |
Clicking rebase for linter fix and queuing up to merge. |
These currently refer to rawhide but naming them rawhide is hard in our stack. Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
d43c1cf
to
4bfa3ae
Compare
SSIA.