test/scripts/generate-gitlab-ci: mimic matrix syntax of jobnames #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achilleas-k
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
This is a much smaller change than I thought it would be and, more importantly, IT WORKS!
Makes the gitlab CI pipeline view tidier too, though not sure if it's better or worse for navigating the jobs. Probably equally difficult, if I'm being honest.
Thanks. LGTM!
|
#1225 fixes the linting problem and needs a second approval |
achilleas-k
force-pushed
the
mimic-matrix-jobnames
branch
from
d5b6170 to
990f31e
Compare
|
Rebased for linter config fix. |
The job_names are used in metrics (cloudability) to get an overview of runtimes per "curated_job_name". This "curated_job_name" is deduced by splitting by ":", which exists when using matrix-jobs. e.g. https://github.com/osbuild/osbuild-composer/blob/a237447ca06c3f302e41c710a64e86577cfd2537/.gitlab-ci.yml#L111 As we generate the jobs with the script `generate-gitlab-ci`, this implementation should work to mimic the behavior and have the same names as if they were matrix-jobs.
schuellerf
force-pushed
the
mimic-matrix-jobnames
branch
from
990f31e to
764a942
Compare
|
@thozza could this cause problems, from your experience with CI/CD stuff? |
|
…rebased for #1226, too |
|
Something got stuck in the queue and I had to remove it and queue it up again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The job_names are used in metrics (cloudability) to get an overview of run times per "curated_job_name". This "curated_job_name" is deduced by splitting by ":", which exists when using matrix-jobs. e.g. https://github.com/osbuild/osbuild-composer/blob/a237447ca06c3f302e41c710a64e86577cfd2537/.gitlab-ci.yml#L111
As we generate the jobs with the script
generate-gitlab-ci, this implementation should work to mimic the behavior and have the same names as if they were matrix-jobs.I'll set to draft to collect enough feedback if this is a good idea…