From 8b197bf2dfe89495c125b151d710cd26d7bca7ac Mon Sep 17 00:00:00 2001
From: Lucas Guillermou <lucas@opsmill.com>
Date: Mon, 23 Sep 2024 14:52:16 +0200
Subject: [PATCH] Add missing docs link for
 GeneratorDefinition/GeneratorInstance

---
 backend/infrahub/core/models.py                  | 4 +---
 backend/infrahub/core/schema/basenode_schema.py  | 4 ++--
 backend/infrahub/core/schema/definitions/core.py | 2 ++
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/backend/infrahub/core/models.py b/backend/infrahub/core/models.py
index 6888cd2eb7..81628afd72 100644
--- a/backend/infrahub/core/models.py
+++ b/backend/infrahub/core/models.py
@@ -513,9 +513,7 @@ def diff(self, other: Self) -> HashableModelDiff:
         in_both, local_only, other_only = compare_lists(
             list1=list(self.model_fields.keys()), list2=list(other.model_fields.keys())
         )
-        diff_result = HashableModelDiff(
-            added={item: None for item in local_only}, removed={item: None for item in other_only}
-        )
+        diff_result = HashableModelDiff(added=dict.fromkeys(local_only), removed=dict.fromkeys(other_only))
 
         for field_name in in_both:
             if field_name.startswith("_") or field_name in self._exclude_from_hash:
diff --git a/backend/infrahub/core/schema/basenode_schema.py b/backend/infrahub/core/schema/basenode_schema.py
index 63eb96e067..b5fe047bd5 100644
--- a/backend/infrahub/core/schema/basenode_schema.py
+++ b/backend/infrahub/core/schema/basenode_schema.py
@@ -143,9 +143,9 @@ def _diff_element(
 
         elements_diff = HashableModelDiff()
         if present_local:
-            elements_diff.added = {name: None for name in present_local}
+            elements_diff.added = dict.fromkeys(present_local)
         if present_other:
-            elements_diff.removed = {name: None for name in present_other}
+            elements_diff.removed = dict.fromkeys(present_other)
 
         # Process element b
         for name in sorted(present_both):
diff --git a/backend/infrahub/core/schema/definitions/core.py b/backend/infrahub/core/schema/definitions/core.py
index f40e16adcd..91502d2759 100644
--- a/backend/infrahub/core/schema/definitions/core.py
+++ b/backend/infrahub/core/schema/definitions/core.py
@@ -1801,6 +1801,7 @@
             "uniqueness_constraints": [["name__value"]],
             "generate_profile": False,
             "inherit_from": [InfrahubKind.TASKTARGET],
+            "documentation": "/topics/generator",
             "attributes": [
                 {"name": "name", "kind": "Text", "unique": True},
                 {"name": "description", "kind": "Text", "optional": True},
@@ -1848,6 +1849,7 @@
             "branch": BranchSupportType.LOCAL.value,
             "generate_profile": False,
             "inherit_from": [InfrahubKind.TASKTARGET],
+            "documentation": "/topics/generator",
             "attributes": [
                 {"name": "name", "kind": "Text"},
                 {