Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A11Y] Improve text scaling in promoted story card #4703

Closed
vrajdesai78 opened this issue Nov 8, 2022 · 4 comments
Closed

[A11Y] Improve text scaling in promoted story card #4703

vrajdesai78 opened this issue Nov 8, 2022 · 4 comments
Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.

Comments

@vrajdesai78
Copy link
Contributor

Describe the bug
With current implementation of promoted story card, accessibility scanner shows suggestion to improve text scaling as the container inside which scalable text is used has a fixed width (though we might have used sp to make it scalable). We need to introduce a new design for promoted story card such that it will pass accessibility scanner also doesn't produce #4684 issue again.

image

We can introduce a new design like above screenshot where we can set full width to the cards i.e. match _parent (with appropriate margins) which will remove the issue of accessibility. We can also show the dots at bottom which represent the number + position of items.

image

For sighted users

  • The banners will be cyclic i.e. item-0,item1,item2,item0 and repeat

For talkback users

  • The cyclic nature will stop
  • The screenreader will start from item-0, item 1, item-2 and next it will go out of list.

To Reproduce
Steps to reproduce the behavior:

  1. Turn on accessibility scanner
  2. Visit Home Screen

Expected behavior
Accessibility scanner should not show any suggestion to improve text scaling and also we should not re-create #4684 issue again.

Screenshot of accessibility scanner showing improvement
image

Environment

  • Device/emulator being used: Realme GT Master Edition
  • Android or SDK version (e.g. Android 5 or SDK 21): Android 12
  • App version (you can get this through system app settings or via the admin controls menu in-app): 1.0
@rt4914 rt4914 changed the title Improve text scaling in promoted story card [A11Y] Improve text scaling in promoted story card Nov 9, 2022
@rt4914 rt4914 added the Priority: Essential This work item must be completed for its milestone. label Nov 9, 2022
@vishisht-dubey
Copy link

Hii i would like to contribute in this issue
please assign me with this one

@BenHenning
Copy link
Member

BenHenning commented Nov 15, 2022

This is more of a feature and will require a lot of familiarity with the app in order to work on it @vishisht08. Might I suggest one of our other issues, instead? They may be more approachable in helping you get up-to-speed with the app before trying to tackle this issue.

@adhiamboperes adhiamboperes added Impact: Low Low perceived user impact (e.g. edge cases). enhancement End user-perceivable enhancements. Work: High It's not clear what the solution is. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. and removed Priority: Essential This work item must be completed for its milestone. Work: High It's not clear what the solution is. labels Sep 25, 2023
@BenHenning BenHenning added this to the 1.0 Global availability milestone Aug 29, 2024
@manas-yu
Copy link
Collaborator

manas-yu commented Feb 4, 2025

Hi @adhiamboperes, the accessibility scanner currently does not display the "improve text scaling" suggestion in the home screen, so I just wanted to confirm the issue requirements.

Image

@adhiamboperes
Copy link
Collaborator

Thanks @manas-yu. I am happy to close this for now based on your findings.

@adhiamboperes adhiamboperes closed this as not planned Won't fix, can't repro, duplicate, stale Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.
Development

No branches or pull requests

7 participants