-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[A11Y] Improve text scaling in promoted story card #4703
Comments
Hii i would like to contribute in this issue |
This is more of a feature and will require a lot of familiarity with the app in order to work on it @vishisht08. Might I suggest one of our other issues, instead? They may be more approachable in helping you get up-to-speed with the app before trying to tackle this issue. |
Hi @adhiamboperes, the accessibility scanner currently does not display the "improve text scaling" suggestion in the home screen, so I just wanted to confirm the issue requirements. |
Thanks @manas-yu. I am happy to close this for now based on your findings. |
Describe the bug
With current implementation of promoted story card, accessibility scanner shows suggestion to improve text scaling as the container inside which scalable text is used has a fixed width (though we might have used sp to make it scalable). We need to introduce a new design for promoted story card such that it will pass accessibility scanner also doesn't produce #4684 issue again.
We can introduce a new design like above screenshot where we can set full width to the cards i.e. match _parent (with appropriate margins) which will remove the issue of accessibility. We can also show the dots at bottom which represent the number + position of items.
For sighted users
For talkback users
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Accessibility scanner should not show any suggestion to improve text scaling and also we should not re-create #4684 issue again.
Screenshot of accessibility scanner showing improvement

Environment
The text was updated successfully, but these errors were encountered: