Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audio language is auto changed to English after selecting Default audio language #4373

Closed
KolliAnitha opened this issue May 23, 2022 · 4 comments
Closed

Audio language is auto changed to English after selecting Default audio language #4373

KolliAnitha opened this issue May 23, 2022 · 4 comments
Assignees
@KolliAnitha
Labels
Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@KolliAnitha
Copy link

KolliAnitha commented May 23, 2022 •
edited
Loading

Describe the bug
Audio language is auto changed to English after selecting Default audio language

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'What is a Ratio?' Chapter
  2. Click on audio symbol- Change the language to Hindi
  3. Now click on Options- Default Audio Language- Set to No Audio
  4. Now open the Audio language options
  5. English is selected as the Audio language instead if Hindi

Expected behavior:
Audio language should be Hindi as it is selected by user

22-05-23-18-19-04.mp4

Environment:
Device name: One plus Nord2 5G
Android version : Android 11
App version: 0.7-alpha-6c08d882d3
@Broppia Broppia added the Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). label May 31, 2022
@BenHenning BenHenning added this to the Beta MR2 milestone Jun 11, 2022
@BenHenning BenHenning added issue_user_learner Z-ibt Temporary label for Ben to keep track of issues he's triaged. and removed issue_type_bug labels Sep 15, 2022
@BenHenning BenHenning removed this from the Beta MR2 milestone Sep 16, 2022
@debz-g
Copy link

debz-g commented Jan 23, 2023

I tried replicating the issue with the above steps on the latest branch as of today. It seems the issue has been solved.

Tested on: Pixel 6 Android 13

@seanlip
Copy link
Member

seanlip commented Jan 24, 2023

Thanks @debz-g for checking. @KolliAnitha could you please double-confirm with the latest build so we can close this issue? Thanks!

@KolliAnitha
Copy link
Author

KolliAnitha commented Jan 24, 2023 •
edited
Loading

@seanlip, now there is no option for 'No audio' in the Options layout. If I change to any other language and open the audio language it is working fine.

Screenshot_2023-01-24-08-36-05-44_943a62cb4c6fb83e010e1c2e82766a17

@seanlip
Copy link
Member

seanlip commented Jan 24, 2023 •
edited
Loading

Yup, the "No audio" was removed in this PR: #4575 (the reasoning is there as well). So I think this issue can be closed. Thanks @debz-g for checking on this, and @KolliAnitha for re-verifying!

@seanlip seanlip closed this as completed Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KolliAnitha KolliAnitha

Labels
Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@seanlip @BenHenning @debz-g @KolliAnitha @Broppia