Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "DefaultAudioFragment" to "AudioLanguageFragment" #1901

Closed
MohamedMedhat1998 opened this issue Sep 24, 2020 · 9 comments · Fixed by #1910
Closed

Rename "DefaultAudioFragment" to "AudioLanguageFragment" #1901

MohamedMedhat1998 opened this issue Sep 24, 2020 · 9 comments · Fixed by #1910
Assignees
@Arjupta
Labels
good first issue This item is good for new contributors to make their pull request. Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@MohamedMedhat1998
Copy link
Contributor

Rename everything related to audio language from "DefaultAudio" to "AudioLanguage"
By everything we mean:

  • Activities
  • Xml Files
  • Variable Names
  • Resources
@rt4914 rt4914 added this to the Backlog milestone Sep 24, 2020
@rt4914 rt4914 added good first issue This item is good for new contributors to make their pull request. Priority: Nice-to-have This work item is nice to have for its milestone. labels Sep 24, 2020
@soamOne
Copy link
Contributor

soamOne commented Sep 24, 2020

Hello @MohamedMedhat1998 Sir. I would like to work on this issue if possible.

@rt4914
Copy link
Contributor

rt4914 commented Sep 24, 2020

Hello @MohamedMedhat1998 Sir. I would like to work on this issue if possible.

@soamOne I have already assigned you #1882 so please start with that issue first. Thanks.

@MohamedMedhat1998
Copy link
Contributor Author

Hello @MohamedMedhat1998 Sir. I would like to work on this issue if possible.

I agree with @rt4914

@Arjupta
Copy link
Contributor

Arjupta commented Sep 25, 2020 •
edited
Loading

Can I take up with this issue?

@soamOne
Copy link
Contributor

soamOne commented Sep 25, 2020

Sure @MohamedMedhat1998 @rt4914 .

@aggarwalpulkit596
Copy link
Contributor

@erwinkaaai think @soamOne is already working on it.In the meantime you can start with some other good first issu

@rt4914
Copy link
Contributor

rt4914 commented Sep 25, 2020

Can I take up with this issue?

Assigning this issue to @Arjupta as it was available when the contributor commented.

cc: @BenHenning

@rt4914
Copy link
Contributor

rt4914 commented Sep 25, 2020

Hi! I would like to work on this issue if possible!

Hello @erwinkaaa . Welcome to Oppia.
Before we assign you any issues to work on have a look at wiki first. This will help you in setting up the project and once you sign the CLA and fill the survey form we can assign you issues to work on.

Arjupta added a commit to Arjupta/oppia-android that referenced this issue Sep 26, 2020
@Arjupta
Fixes bug oppia#1901
32bd862 
Refractored occurrences of DefaultAudio to AudioLanguage in every file
@Arjupta
Copy link
Contributor

Arjupta commented Sep 27, 2020 •
edited
Loading

Sir after refactoring the code from default audio to audio language , the dagger test component were not recognized by Android studio ,when I tried rebuilding it the build was successfully done but the error persists. Maybe that's the reason my PR is failing. Kindly help @MohamedMedhat1998

@Arjupta Arjupta mentioned this issue Sep 27, 2020
Merged
8 tasks
Arjupta added a commit to Arjupta/oppia-android that referenced this issue Sep 27, 2020
@Arjupta
Fixes oppia#1901 :
4721c4a 
Refactored occurrences of DefaultAudio to AudioLanguage wherever required
Arjupta added a commit to Arjupta/oppia-android that referenced this issue Sep 27, 2020
@Arjupta
Fixes oppia#1901: Rename "DefaultAudioFragment" to "AudioLanguageFrag…
40a9d25 
…ment"
MohamedMedhat1998 pushed a commit that referenced this issue Sep 27, 2020
@Arjupta
Fixes #1901: Rename "DefaultAudioFragment" to "AudioLanguageFragment" (…
bab5c1a 
…#1910)

* Fixes bug #1901

Refractored occurrences of DefaultAudio to AudioLanguage in every file

* Fixes #1901 :
Refactored occurrences of DefaultAudio to AudioLanguage wherever required

* Fixes #1901: Rename "DefaultAudioFragment" to "AudioLanguageFragment"
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arjupta Arjupta

Labels
good first issue This item is good for new contributors to make their pull request. Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #1901: Rename "DefaultAudioFragment" to "AudioLanguageFragment" Arjupta/oppia-android
6 participants
@MohamedMedhat1998 @rt4914 @BenHenning @aggarwalpulkit596 @Arjupta @soamOne