Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XLA:CPU] Replace colons with underscores in ConvertToCName. #23180

Merged
merged 1 commit into from
Feb 27, 2025
+7 −1
Merged

[XLA:CPU] Replace colons with underscores in ConvertToCName. #23180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion xla/backends/cpu/codegen/symbol_name_util.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ bool isValidCVariableName(absl::string_view name) {
}

absl::StatusOr<std::string> ConvertToCName(absl::string_view name) {
auto maybe_c_name = absl::StrReplaceAll(name, {{".", "_"}, {"-", "_"}});
auto maybe_c_name =
absl::StrReplaceAll(name, {{".", "_"}, {"-", "_"}, {":", "_"}});
if (isValidCVariableName(maybe_c_name)) {
return maybe_c_name;
}
Expand Down
5 changes: 5 additions & 0 deletions xla/backends/cpu/codegen/symbol_name_util_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,11 @@ TEST(SymbolNameUtilTest, Dash) {
EXPECT_EQ(result, "foo_bar");
}

TEST(SymbolNameUtilTest, Colon) {
TF_ASSERT_OK_AND_ASSIGN(auto result, xla::cpu::ConvertToCName("foo:bar"));
EXPECT_EQ(result, "foo_bar");
}

TEST(SymbolNameUtilTest, CantConvertToCNameInvalid) {
EXPECT_FALSE(xla::cpu::ConvertToCName("1_test").ok());
}
Expand Down
Loading