[XLA:GPU] use eraseNamedMetadata instead of eraseNamedMDNode #23174
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
eraseNamedMDNode does not clean the hash map that getNamedMetadata method uses. As a result the hash map keeps pointer to a deleted node and this leads to UseAfterFree crash. PiperOrigin-RevId: 731626893
copybara-service
bot
force-pushed
the
test_731626893
branch
from
e449f91 to
31c0b14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[XLA:GPU] use eraseNamedMetadata instead of eraseNamedMDNode
eraseNamedMDNode does not clean the hash map that getNamedMetadata method uses.
As a result the hash map keeps pointer to a deleted node and this leads to UseAfterFree crash.