Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XLA:GPU] Remove unused should_process callback in pipeliner #22963

Merged
merged 1 commit into from
Feb 27, 2025
Merged

[XLA:GPU] Remove unused should_process callback in pipeliner #22963

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions xla/service/collective_pipeliner.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2672,7 +2672,7 @@ absl::Status TransformLoopForwardSink(const WhileLoopAnalysis& loop_analysis,
static absl::Status TransformLoopBackward(
const WhileLoopAnalysis& loop_analysis, bool insert_non_alias_custom_call,
int64_t level_to_operate_on, bool process_different_sized_ops,
HloPredicate should_process, HloPredicate acceptable_formatting,
HloPredicate acceptable_formatting,
CollectivePipeliner::HloPostprocessor postprocess_peeled,
CollectivePipeliner::HloPostprocessor postprocess_rotated,
CollectivePipeliner::HloPostprocessor postprocess_peeled_trailing_op,
Expand Down Expand Up @@ -3119,8 +3119,8 @@ absl::StatusOr<bool> CollectivePipeliner::RunPipeliner(
CHECK_EQ(config_.pipelining_direction, PipeliningDirection::kBackward);
TF_RETURN_IF_ERROR(TransformLoopBackward(
*loop_analysis, !config_.last_run, config_.level_to_operate_on,
config_.process_different_sized_ops, config_.should_process,
config_.acceptable_formatting, config_.postprocess_backward_peeled_op,
config_.process_different_sized_ops, config_.acceptable_formatting,
config_.postprocess_backward_peeled_op,
config_.postprocess_backward_rotated_op,
config_.postprocess_backward_peeled_trailing_op, next_channel_id,
config_.postprocess_pipelined_ops));
Expand Down
Loading