[XLA:CPU] Replace colons with underscores in ConvertToCName.

PiperOrigin-RevId: 731693136
openxla · Feb 27, 2025 · 7787a5f · 7787a5f
1 parent bbb5d31
commit 7787a5f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/xla/backends/cpu/codegen/symbol_name_util.cc b/xla/backends/cpu/codegen/symbol_name_util.cc
@@ -46,7 +46,8 @@ bool isValidCVariableName(absl::string_view name) {
 }
 
 absl::StatusOr<std::string> ConvertToCName(absl::string_view name) {
-  auto maybe_c_name = absl::StrReplaceAll(name, {{".", "_"}, {"-", "_"}});
+  auto maybe_c_name =
+      absl::StrReplaceAll(name, {{".", "_"}, {"-", "_"}, {":", "_"}});
   if (isValidCVariableName(maybe_c_name)) {
     return maybe_c_name;
   }

diff --git a/xla/backends/cpu/codegen/symbol_name_util_test.cc b/xla/backends/cpu/codegen/symbol_name_util_test.cc
@@ -35,6 +35,11 @@ TEST(SymbolNameUtilTest, Dash) {
   EXPECT_EQ(result, "foo_bar");
 }
 
+TEST(SymbolNameUtilTest, Colon) {
+  TF_ASSERT_OK_AND_ASSIGN(auto result, xla::cpu::ConvertToCName("foo:bar"));
+  EXPECT_EQ(result, "foo_bar");
+}
+
 TEST(SymbolNameUtilTest, CantConvertToCNameInvalid) {
   EXPECT_FALSE(xla::cpu::ConvertToCName("1_test").ok());
 }