Skip to content
This repository was archived by the owner on Aug 28, 2023. It is now read-only.

Commit 556ca8f

Browse files
authored
[82812] Remove deprecated OMZ tab and components (part 1) (#69)
1 parent 4f45e6d commit 556ca8f

36 files changed

+333
-1170
lines changed

.features.json

+1-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
11
{
2-
"DYNAMIC_SHAPES": 0,
3-
"OMZ_REDESIGN": 1,
4-
"HUGGING_FACE_MODELS": 1
2+
"DYNAMIC_SHAPES": 0
53
}

client/e2e/src/model-import-form.e2e-spec.ts

+3-4
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
import { browser, by, element, ElementArrayFinder, ElementFinder, protractor } from 'protractor';
22

3-
import { ModelColorChannels, TransformationsConfigType } from '@store/model-store/model.model';
3+
import { ModelColorChannels, ModelPrecisionEnum, TransformationsConfigType } from '@store/model-store/model.model';
44

55
import { TestUtils } from './pages/test-utils';
66
import { Helpers } from './pages/helpers';
7-
import { OMZModelPrecisionEnum } from '../../src/app/modules/model-manager/components/model-downloader-table/model-downloader-table.component';
87
import { isMXNetModel, isTensorFlowModel, ModelFile } from './pages/model-file';
98

109
describe('UI tests for model import form', () => {
@@ -234,8 +233,8 @@ describe('UI tests for model import form', () => {
234233
browser.params.defaultTimeout
235234
);
236235
await checkDropDownAndSetValue(testUtils.modelManagerPage.precisionContainer, conversionSettings.precision, [
237-
OMZModelPrecisionEnum.FP32,
238-
OMZModelPrecisionEnum.FP16,
236+
ModelPrecisionEnum.FP32,
237+
ModelPrecisionEnum.FP16,
239238
]);
240239
expect(await testUtils.modelManagerPage.isParameterSatisfied('dataType-tip')).toBeTruthy(
241240
'Precision tip should shows that precision drop down is filled'

client/e2e/src/pages/hugging-face-model-download.po.ts

+5-4
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
import { browser, by, element, ElementArrayFinder, ElementFinder, protractor } from 'protractor';
22

3+
import { ModelPrecisionEnum } from '@store/model-store/model.model';
4+
35
import { TestUtils } from './test-utils';
46
import { ModelFile } from './model-file';
5-
import { OMZModelPrecisionEnum } from '../../../src/app/modules/model-manager/components/model-downloader-table/model-downloader-table.component';
67

78
export const filterGroupNames = ['task', 'library', 'model-type', 'language', 'license'];
89
type FilterGroupName = typeof filterGroupNames[number];
@@ -163,7 +164,7 @@ export class HFModelDownloadPage {
163164
}
164165

165166
async convertDownloadedModelToIR(
166-
precision?: OMZModelPrecisionEnum,
167+
precision?: ModelPrecisionEnum.FP32 | ModelPrecisionEnum.FP16,
167168
configurationMultiplier: number = 4
168169
): Promise<void> {
169170
// Wait for the environment preparing to complete
@@ -183,14 +184,14 @@ export class HFModelDownloadPage {
183184
);
184185

185186
if (precision) {
186-
if (precision !== OMZModelPrecisionEnum.FP16) {
187+
if (precision !== ModelPrecisionEnum.FP16) {
187188
await this.selectPrecision(precision);
188189
} else {
189190
console.log('select FP16');
190191
await browser.sleep(2000);
191192
}
192193
} else {
193-
await this.selectPrecision(OMZModelPrecisionEnum.FP32);
194+
await this.selectPrecision(ModelPrecisionEnum.FP32);
194195
}
195196

196197
await browser.wait(this.until.elementToBeClickable(this.elements.convertButton), browser.params.defaultTimeout * 3);

client/e2e/src/pages/model-download.po.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ export class ModelDownloadPage {
88
until = protractor.ExpectedConditions;
99

1010
private readonly elements = {
11-
// TODO: change test-id
12-
OMZTab: TestUtils.getElementByDataTestId('open_model_zoo_(v2)'),
11+
OMZTab: TestUtils.getElementByDataTestId('open_model_zoo'),
1312
searchField: TestUtils.getNestedElementByDataTestId(
1413
TestUtils.getElementByDataTestId('search-form-field'),
1514
'search'

client/e2e/src/pages/model-file.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { OMZModelPrecisionEnum } from '../../../src/app/modules/model-manager/components/model-downloader-table/model-downloader-table.component';
1+
import { ModelPrecisionEnum } from '@store/model-store/model.model';
22

33
export type FrameworkType = 'OpenVINO IR' | 'MxNet' | 'Caffe' | 'ONNX' | 'TensorFlow' | 'TensorFlow V2';
44
export type ColorSpace = 'RGB' | 'BGR' | 'Grayscale';
@@ -82,7 +82,7 @@ interface Tokenizer {
8282

8383
interface ConversionSettings {
8484
colourSpace?: ColorSpace;
85-
precision?: OMZModelPrecisionEnum;
85+
precision?: ModelPrecisionEnum.FP32 | ModelPrecisionEnum.FP16;
8686
framework: FrameworkType;
8787
outputs: string[];
8888
irVersion: number;

client/e2e/src/pages/model-manager.po.ts

-4
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,6 @@ export class ModelManagerPage {
4646
return TestUtils.getElementByDataTestId('original_model');
4747
}
4848

49-
get OMZTab(): ElementFinder {
50-
return TestUtils.getElementByDataTestId('open_model_zoo');
51-
}
52-
5349
get modelFrameworkContainer() {
5450
return element(by.id('framework'));
5551
}

client/src/app/modules/model-manager/components/base-model-zoo-import/base-model-zoo-import.component.ts

+8
Original file line numberDiff line numberDiff line change
@@ -59,12 +59,20 @@ export abstract class BaseModelZooImportComponent<T, U = string> implements Afte
5959
},
6060
};
6161

62+
readonly failedModelsFetchingTemplateContext = {
63+
action: () => {
64+
this._triggerModelsLoading();
65+
},
66+
};
67+
6268
protected readonly _unsubscribe$ = new Subject<void>();
6369

6470
protected constructor() {
6571
this._subscribeToSortAndFiltersChanges();
6672
}
6773

74+
protected abstract _triggerModelsLoading(): void;
75+
6876
protected abstract get _dataSourceFilter(): U;
6977

7078
abstract importModel(): void;

client/src/app/modules/model-manager/components/hugging-face-import-ribbon-content/hugging-face-import-ribbon-content.component.html

+9-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<wb-model-zoo-layout [isDetailsOpened]="!!selectedModel">
2-
<wb-model-zoo-content #modelZooContent [loading]="isLoading$ | async">
2+
<wb-model-zoo-content #modelZooContent [loading]="isLoading$ | async" [hasError]="!!(error$ | async)">
33
<wb-config-form-field
44
ngProjectAs="model-zoo-sort"
55
[field]="sortField"
@@ -65,6 +65,8 @@
6565
</wb-card-content-row>
6666
</wb-card>
6767
</wb-card-grid>
68+
69+
<ng-container ngProjectAs="wb-model-zoo-error" [ngTemplateOutlet]="failedModelsFetchingTemplate"></ng-container>
6870
</wb-model-zoo-content>
6971

7072
<wb-huggingface-model-details
@@ -152,3 +154,9 @@
152154
*ngTemplateOutlet="modelZooContent.emptyFilteredModelsTemplate; context: emptyFilteredModelsTemplateContext"
153155
></ng-container>
154156
</ng-template>
157+
158+
<ng-template #failedModelsFetchingTemplate>
159+
<ng-container
160+
*ngTemplateOutlet="modelZooContent.failedModelsFetchingTemplate; context: failedModelsFetchingTemplateContext"
161+
></ng-container>
162+
</ng-template>

client/src/app/modules/model-manager/components/hugging-face-import-ribbon-content/hugging-face-import-ribbon-content.component.ts

+6-1
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ export class HuggingFaceImportRibbonContentComponent
4343

4444
private readonly _modelData$ = this._store$.select(HuggingfaceModelStoreSelectors.selectModelsData);
4545
readonly isLoading$ = this._store$.select(HuggingfaceModelStoreSelectors.selectLoading);
46+
readonly error$ = this._store$.select(HuggingfaceModelStoreSelectors.selectError);
4647

4748
readonly dataSource = new HuggingfaceModelZooDataSource();
4849

@@ -80,14 +81,18 @@ export class HuggingFaceImportRibbonContentComponent
8081
this._cdr.detectChanges();
8182
});
8283

83-
this._store$.dispatch(HuggingfaceModelStoreActions.loadModelData());
84+
this._triggerModelsLoading();
8485
}
8586

8687
ngOnDestroy(): void {
8788
super.ngOnDestroy();
8889
this._store$.dispatch(HuggingfaceModelStoreActions.reset());
8990
}
9091

92+
protected _triggerModelsLoading(): void {
93+
this._store$.dispatch(HuggingfaceModelStoreActions.loadModelData());
94+
}
95+
9196
protected get _dataSourceFilter(): IHuggingfaceModelZooFilter {
9297
return {
9398
id: this.searchControl.value,

client/src/app/modules/model-manager/components/model-downloader-table/model-downloader-table.component.html

-135
This file was deleted.

client/src/app/modules/model-manager/components/model-downloader-table/model-downloader-table.component.scss

-78
This file was deleted.

0 commit comments

Comments
 (0)