add sample test in python_tests and update comments in src files

Author: apinge

.github/workflows/linux.yml

@@ -380,6 +380,7 @@ jobs:
           LD_LIBRARY_PATH: "${{ env.INSTALL_DIR }}/runtime/lib/intel64:${{ env.INSTALL_DIR }}/runtime/3rdparty/tbb/lib:$LD_LIBRARY_PATH" # Required for C++ samples
           SAMPLES_PY_DIR: "${{ env.INSTALL_DIR }}/samples/python"
           SAMPLES_CPP_DIR: "${{ env.INSTALL_DIR }}/samples_bin"
+          SAMPLES_C_DIR: "${{ env.INSTALL_DIR }}/samples/c"
 
   genai_build_nodejs_bindings:
     name: Build Node.js bindings

.github/workflows/mac.yml

@@ -396,6 +396,7 @@ jobs:
         env:
           SAMPLES_PY_DIR: "${{ env.INSTALL_DIR }}/samples/python"
           SAMPLES_CPP_DIR: "${{ env.INSTALL_DIR }}/samples_bin"
+          SAMPLES_C_DIR: "${{ env.INSTALL_DIR }}/samples/c"
 
   Overall_Status:
     name: ci/gha_overall_status_macos

.github/workflows/windows.yml

@@ -475,6 +475,7 @@ jobs:
           PATH: "${{ env.INSTALL_DIR }}/runtime/bin/intel64/${{ matrix.build-type }};${{ env.INSTALL_DIR }}/runtime/3rdparty/tbb/bin;%PATH%" # Required for C++ samples
           SAMPLES_PY_DIR: "${{ env.INSTALL_DIR }}/samples/python"
           SAMPLES_CPP_DIR: "${{ env.INSTALL_DIR }}/samples_bin"
+          SAMPLES_C_DIR: "${{ env.INSTALL_DIR }}/samples/c"
 
   genai_nodejs_tests:
     name: Node.js bindings tests

src/c/include/openvino/genai/c/llm_pipeline_c.h

@@ -75,6 +75,8 @@ OPENVINO_GENAI_C_EXPORTS ov_status_e ov_genai_llm_pipeline_create(const char* mo
                                                                   const char* device,
                                                                   ov_genai_llm_pipeline** pipe);
 
+// TODO: Add 'const ov::AnyMap& properties' as an input argument when creating ov_genai_llm_pipeline.
+
 /**
  * @brief Release the memory allocated by ov_genai_llm_pipeline.
  * @param model A pointer to the ov_genai_llm_pipeline.

src/c/include/openvino/genai/c/perf_metrics_c.h

@@ -132,7 +132,8 @@ ov_genai_perf_metrics_get_detokenization_duration(const ov_genai_perf_metrics* m
 /**
  * @brief C interface for PerfMetrics& operator+=(const PerfMetrics& right)
  *
- * This function adds the PerfMetrics from 'right' to 'left' in place.
+ * This function adds the PerfMetrics from 'right' to 'left' in place. Equivalent to ov::genai::PerfMetrics&
+ * operator+=(const ov::genai::PerfMetrics&);
  *
  * @param left A pointer to the ov_genai_perf_metrics that will be updated.
  * @param right A pointer to the ov_genai_perf_metrics whose metrics will be added to 'left'.

src/c/src/perf_metrics_c.cpp

@@ -166,8 +166,6 @@ ov_status_e ov_genai_perf_metrics_get_detokenization_duration(const ov_genai_per
     }
     return ov_status_e::OK;
 }
-
-// PerfMetrics& operator+=(const PerfMetrics& right);
 ov_status_e ov_genai_perf_metrics_add_in_place(ov_genai_perf_metrics* left, const ov_genai_perf_metrics* right) {
     if (!left || !(left->object) || !right || !(right->object)) {
         return ov_status_e::INVALID_C_PARAM;

tests/python_tests/samples/conftest.py

@@ -62,6 +62,7 @@
 
 SAMPLES_PY_DIR = os.environ.get("SAMPLES_PY_DIR", os.path.abspath(os.path.join(os.path.dirname(__file__), "../../../samples/python")))
 SAMPLES_CPP_DIR = os.environ.get("SAMPLES_CPP_DIR", os.getcwd())
+SAMPLES_C_DIR = os.environ.get("SAMPLES_C_DIR", os.path.abspath(os.path.join(os.path.dirname(__file__), "../../../samples/c")))
 
 @pytest.fixture(scope="session", autouse=True)
 def setup_and_teardown(request, tmp_path_factory):

tests/python_tests/samples/test_greedy_causal_lm.py

@@ -5,7 +5,7 @@
 import pytest
 import sys
 
-from conftest import SAMPLES_PY_DIR, SAMPLES_CPP_DIR
+from conftest import SAMPLES_PY_DIR, SAMPLES_CPP_DIR, SAMPLES_C_DIR
 from test_utils import run_sample
 
 class TestGreedyCausalLM:
@@ -31,5 +31,11 @@ def test_sample_greedy_causal_lm(self, convert_model, sample_args):
         cpp_command =[cpp_sample, convert_model, sample_args]
         cpp_result = run_sample(cpp_command)
 
+        # Test C sample
+        c_sample = os.path.join(SAMPLES_C_DIR, "text_generation/greedy_causal_lm_c")
+        c_command =[c_sample, convert_model, sample_args]
+        c_result = run_sample(c_command)
+
         # Compare results
         assert py_result.stdout == cpp_result.stdout, f"Results should match"
+        assert cpp_result.stdout == c_result.stdout, f"Results should match"