-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tensorflow tensor support #3340
base: develop
Are you sure you want to change the base?
Add tensorflow tensor support #3340
Conversation
I've implemented the suggested change to the save_file.register decorator. I've also fixed string literals in exceptions in tf_linalg.py and tf_numeric.py to address the pre-commit linting issues that were causing CI failures. The PR should be ready for review now. |
Hi @darshil929 |
…ersion changes, and improve tensor device handling
I'm analyzing the precommit issues now and will get them fixed as soon as possible. |
…w pytest CI checks
Hi @kshpv Sir, I've made several changes to fix the type annotations and error handling issues in the backend implementation that were causing the mypy and pytest/tensorflow CI checks to fail. The changes include:
Could you please review these changes and rerun the CI checks to verify they resolve the issues? Please let me know if any additional adjustments are needed. Thank you! |
I recommend you run tests locally, it speeds up your development. Please, take a look at failed precommit builds, you need to focus on fixing them and ensure that failed tests pass locally. After that I can make a full-fledged review |
Yes sir, I understand. I've been experiencing some environment issues with local test execution, but I'll definitely get those resolved first. I'll update you as soon as I have tested everything locally and verified the fixes. |
Changes
ord=0
in tf_linalg.py's norm functionReason for changes
Right now TensorFlow tensors don't work with nncf.Tensor, which is blocking issue #3041 from being done. This PR adds TensorFlow backend support so we can use TensorFlow tensors with NNCF operations. I'm continuing the work from PR #3106 but fixing some things reviewers pointed out and adding stuff that was missing.
Related tickets
#3041
#3106
Tests