Rename boolean fields in record

Author: vpaturet

src/ext-test/java/org/opentripplanner/ext/siri/AddedTripBuilderTest.java

@@ -155,9 +155,9 @@ void testAddedTrip() {
     assertEquals(SubMode.of(SUB_MODE), route.getNetexSubmode(), "submode should be mapped");
     assertNotEquals(REPLACED_ROUTE, route, "Should not re-use replaced route");
 
-    assertTrue(tripUpdate.isAddedRoute(), "The route is marked as created by real time updater");
+    assertTrue(tripUpdate.routeCreation(), "The route is marked as created by real time updater");
 
-    assertTrue(tripUpdate.isAddedTrip(), "The trip is marked as created by real time updater");
+    assertTrue(tripUpdate.tripCreation(), "The trip is marked as created by real time updater");
 
     TripPattern pattern = tripUpdate.addedTripPattern();
     assertNotNull(pattern);
@@ -246,7 +246,7 @@ void testAddedTripOnAddedRoute() {
       .build();
 
     assertTrue(firstAddedTrip.isSuccess(), "Trip creation should succeed");
-    assertTrue(firstAddedTrip.successValue().isAddedRoute());
+    assertTrue(firstAddedTrip.successValue().routeCreation());
 
     var firstTrip = firstAddedTrip.successValue().tripTimes().getTrip();
 
@@ -323,7 +323,7 @@ void testAddedTripOnExistingRoute() {
     assertSame(REPLACED_ROUTE, trip.getRoute());
 
     // Assert route
-    assertFalse(addedTrip.successValue().isAddedRoute(), "The existing route should be reused");
+    assertFalse(addedTrip.successValue().routeCreation(), "The existing route should be reused");
   }
 
   @Test
@@ -356,7 +356,7 @@ void testAddedTripWithoutReplacedRoute() {
     assertEquals(TRIP_ID, trip.getId(), "Trip should be mapped");
 
     // Assert route
-    assertTrue(addedTrip.successValue().isAddedRoute(), "A new route should be created");
+    assertTrue(addedTrip.successValue().routeCreation(), "A new route should be created");
     Route route = trip.getRoute();
     assertEquals(LINE_REF, route.getId().getId(), "route should be mapped");
     assertEquals(AGENCY, route.getAgency(), "Agency should be taken from replaced route");

src/ext/java/org/opentripplanner/ext/siri/SiriTimetableSnapshotSource.java

@@ -294,7 +294,7 @@ private Result<UpdateSuccess, UpdateError> addTripToGraphAndBuffer(TripUpdate tr
     LocalDate serviceDate = tripUpdate.serviceDate();
 
     final TripPattern pattern;
-    if (tripUpdate.isAddedTripPattern()) {
+    if (tripUpdate.tripPatternCreation()) {
       pattern = tripUpdate.addedTripPattern();
     } else {
       // Get cached trip pattern or create one if it doesn't exist yet
@@ -308,8 +308,8 @@ private Result<UpdateSuccess, UpdateError> addTripToGraphAndBuffer(TripUpdate tr
       tripUpdate.tripTimes(),
       serviceDate,
       tripUpdate.addedTripOnServiceDate(),
-      tripUpdate.isAddedTrip(),
-      tripUpdate.isAddedRoute()
+      tripUpdate.tripCreation(),
+      tripUpdate.routeCreation()
     );
     var result = snapshotManager.updateBuffer(realTimeTripUpdate);
     LOG.debug("Applied real-time data for trip {} on {}", trip, serviceDate);

src/ext/java/org/opentripplanner/ext/siri/TripUpdate.java

@@ -16,15 +16,15 @@
  * @param serviceDate the service date for which this update applies (updates are valid only for one service date)
  * @param addedTripOnServiceDate optionally if this trip update adds a new trip, the TripOnServiceDate corresponding to this new trip.
  * @param addedTripPattern optionally if this trip update adds a new trip pattern , the new trip pattern to this new trip.
- * @param isAddedRoute true if an added trip cannot be registered under an existing route and a new route must be created.
+ * @param routeCreation true if an added trip cannot be registered under an existing route and a new route must be created.
  */
 record TripUpdate(
   StopPattern stopPattern,
   TripTimes tripTimes,
   LocalDate serviceDate,
   @Nullable TripOnServiceDate addedTripOnServiceDate,
   @Nullable TripPattern addedTripPattern,
-  boolean isAddedRoute
+  boolean routeCreation
 ) {
   public TripUpdate {
     Objects.requireNonNull(stopPattern);
@@ -46,14 +46,14 @@ public TripUpdate(
   /**
    * Return true if this trip update creates a new trip pattern.
    */
-  public boolean isAddedTripPattern() {
+  public boolean tripPatternCreation() {
     return addedTripPattern != null;
   }
 
   /**
    * Return true if this trip update creates a new trip.
    */
-  public boolean isAddedTrip() {
+  public boolean tripCreation() {
     return addedTripOnServiceDate != null;
   }
 }

src/main/java/org/opentripplanner/model/RealTimeTripUpdate.java

@@ -13,16 +13,16 @@
  * @param updatedTripTimes the new trip times for the updated trip.
  * @param serviceDate the service date for which this update applies (updates are valid only for one service date)
  * @param addedTripOnServiceDate optionally if this trip update adds a new trip, the TripOnServiceDate corresponding to this new trip.
- * @param isAddedTrip true if this update creates a new trip, not present in scheduled data.
- * @param isAddedRoute true if an added trip cannot be registered under an existing route and a new route must be created.
+ * @param tripCreation true if this update creates a new trip, not present in scheduled data.
+ * @param routeCreation true if an added trip cannot be registered under an existing route and a new route must be created.
  */
 public record RealTimeTripUpdate(
   TripPattern pattern,
   TripTimes updatedTripTimes,
   LocalDate serviceDate,
   @Nullable TripOnServiceDate addedTripOnServiceDate,
-  boolean isAddedTrip,
-  boolean isAddedRoute
+  boolean tripCreation,
+  boolean routeCreation
 ) {
   public RealTimeTripUpdate {
     Objects.requireNonNull(pattern);

src/main/java/org/opentripplanner/model/TimetableSnapshot.java

@@ -315,10 +315,10 @@ public Result<UpdateSuccess, UpdateError> update(RealTimeTripUpdate realTimeTrip
     addPatternToIndex(pattern);
 
     Route route = trip.getRoute();
-    if (realTimeTripUpdate.isAddedRoute()) {
+    if (realTimeTripUpdate.routeCreation()) {
       realtimeAddedRoutes.put(route.getId(), route);
     }
-    if (realTimeTripUpdate.isAddedTrip()) {
+    if (realTimeTripUpdate.tripCreation()) {
       FeedScopedId tripId = trip.getId();
       realTimeAddedTrips.put(tripId, trip);
       realTimeAddedPatternForTrip.put(trip, pattern);