Add more tests

Author: optionsome

src/test/java/org/opentripplanner/transit/model/timetable/RealTimeTripTimesTest.java

@@ -402,6 +402,17 @@ public void testNoData() {
     assertFalse(updatedTripTimesA.isNoDataStop(2));
   }
 
+  @Test
+  public void testRealTimeUpdated() {
+    RealTimeTripTimes updatedTripTimesA = createInitialTripTimes().copyScheduledTimes();
+    assertFalse(updatedTripTimesA.isRealTimeUpdated(1));
+    updatedTripTimesA.setRealTimeState(RealTimeState.UPDATED);
+    assertTrue(updatedTripTimesA.isRealTimeUpdated(1));
+    updatedTripTimesA.setNoData(1);
+    assertTrue(updatedTripTimesA.isRealTimeUpdated(0));
+    assertFalse(updatedTripTimesA.isRealTimeUpdated(1));
+  }
+
   @Nested
   class GtfsStopSequence {
 

src/test/java/org/opentripplanner/transit/service/DefaultTransitServiceTest.java

@@ -1,6 +1,7 @@
 package org.opentripplanner.transit.service;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.opentripplanner.model.plan.PlanTestConstants.T11_30;
 import static org.opentripplanner.transit.model.basic.TransitMode.BUS;
 import static org.opentripplanner.transit.model.basic.TransitMode.FERRY;
 import static org.opentripplanner.transit.model.basic.TransitMode.RAIL;
@@ -12,16 +13,23 @@
 import java.util.Set;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
+import org.opentripplanner.framework.i18n.I18NString;
+import org.opentripplanner.graph_builder.issue.api.DataImportIssueStore;
 import org.opentripplanner.model.TimetableSnapshot;
+import org.opentripplanner.model.calendar.CalendarServiceData;
 import org.opentripplanner.transit.model._data.TransitModelForTest;
 import org.opentripplanner.transit.model.framework.Deduplicator;
+import org.opentripplanner.transit.model.framework.FeedScopedId;
 import org.opentripplanner.transit.model.network.StopPattern;
 import org.opentripplanner.transit.model.network.TripPattern;
 import org.opentripplanner.transit.model.site.RegularStop;
 import org.opentripplanner.transit.model.site.Station;
 import org.opentripplanner.transit.model.site.StopLocation;
+import org.opentripplanner.transit.model.timetable.DatedTrip;
 import org.opentripplanner.transit.model.timetable.RealTimeTripTimes;
 import org.opentripplanner.transit.model.timetable.ScheduledTripTimes;
+import org.opentripplanner.transit.model.timetable.Trip;
+import org.opentripplanner.transit.model.timetable.TripTimesFactory;
 
 class DefaultTransitServiceTest {
 
@@ -46,6 +54,13 @@ class DefaultTransitServiceTest {
     .withCreatedByRealtimeUpdater(true)
     .build();
 
+  static FeedScopedId CALENDAR_ID = TransitModelForTest.id("CAL_1");
+  static Trip TRIP = TransitModelForTest
+    .trip("123")
+    .withHeadsign(I18NString.of("Trip Headsign"))
+    .withServiceId(CALENDAR_ID)
+    .build();
+
   @BeforeAll
   static void setup() {
     var stopModel = TEST_MODEL
@@ -55,8 +70,23 @@ static void setup() {
       .withStation(STATION)
       .build();
 
-    var transitModel = new TransitModel(stopModel, new Deduplicator());
+    var deduplicator = new Deduplicator();
+    var transitModel = new TransitModel(stopModel, deduplicator);
+    var canceledStopTimes = TEST_MODEL.stopTimesEvery5Minutes(3, TRIP, T11_30);
+    var canceledTripTimes = TripTimesFactory.tripTimes(TRIP, canceledStopTimes, deduplicator);
+    RAIL_PATTERN.add(canceledTripTimes);
+    canceledTripTimes.cancelTrip();
     transitModel.addTripPattern(RAIL_PATTERN.getId(), RAIL_PATTERN);
+
+    // Crate a calendar (needed for testing cancelled trips)
+    CalendarServiceData calendarServiceData = new CalendarServiceData();
+    calendarServiceData.putServiceDatesForServiceId(
+      CALENDAR_ID,
+      List.of(LocalDate.of(2024, 8, 8), LocalDate.of(2024, 8, 9))
+    );
+    transitModel.getServiceCodes().put(CALENDAR_ID, 0);
+    transitModel.updateCalendarServiceData(true, calendarServiceData, DataImportIssueStore.NOOP);
+
     transitModel.index();
 
     transitModel.initTimetableSnapshotProvider(() -> {
@@ -69,6 +99,7 @@ static void setup() {
           .build()
       );
       timetableSnapshot.update(REAL_TIME_PATTERN, tripTimes, LocalDate.now());
+      timetableSnapshot.update(RAIL_PATTERN, canceledTripTimes, LocalDate.now());
 
       return timetableSnapshot.commit();
     });
@@ -115,4 +146,13 @@ void getPatternForStopsWithRealTime() {
     Collection<TripPattern> patternsForStop = service.getPatternsForStop(STOP_B, true);
     assertEquals(Set.of(FERRY_PATTERN, RAIL_PATTERN, REAL_TIME_PATTERN), patternsForStop);
   }
+
+  @Test
+  void getCanceledTrips() {
+    Collection<DatedTrip> canceledTrips = service.getCanceledTrips(null);
+    assertEquals(
+      "[DatedTrip[trip=Trip{F:123 RR123}, serviceDate=2024-08-08], DatedTrip[trip=Trip{F:123 RR123}, serviceDate=2024-08-09]]",
+      canceledTrips.toString()
+    );
+  }
 }