typescript -> ~3.5

Cannot go beyond 3.5 due to GlobalFetch being removed from TS defs in 3.6
@openstax/highlights-client uses GlobalFetch

Author: RoyEJohnson

package.json

@@ -40,7 +40,7 @@
     "ts-loader": "^5.2.1",
     "tslint": "^5.11.0",
     "tslint-loader": "^3.6.0",
-    "typescript": "<3.2",
+    "typescript": "~3.5",
     "typescript-babel-jest": "^1.0.5"
   },
   "resolutions": {

src/serializationStrategies/XpathRangeSelector/xpath.ts

@@ -89,19 +89,19 @@ const floatThroughText = (element: Node, offset: number, container: Node): [Node
 
 const resolveToNextElementOffsetIfPossible = (element: Node, offset: number) => {
   if (isTextOrTextHighlightOrScreenReaderNode(element) && element.parentNode && offset === getMaxOffset(element) && (!element.nextSibling || !isHighlightOrScreenReaderNode(element.nextSibling))) {
-    return [element.parentNode, nodeIndex(element.parentNode.childNodes, element) + 1];
+    return [element.parentNode, nodeIndex(element.parentNode.childNodes, element) + 1] as const;
   }
 
-  return [element, offset];
+  return [element, offset] as const;
 };
 
 const resolveToPreviousElementOffsetIfPossible = (element: Node, offset: number) => {
 
   if (isTextOrTextHighlightOrScreenReaderNode(element) && element.parentNode && offset === 0 && (!element.previousSibling || !isHighlightOrScreenReaderNode(element.previousSibling))) {
-    return [element.parentNode, nodeIndex(element.parentNode.childNodes, element)];
+    return [element.parentNode, nodeIndex(element.parentNode.childNodes, element)] as const;
   }
 
-  return [element, offset];
+  return [element, offset] as const;
 };
 
 // kinda copied from https://developer.mozilla.org/en-US/docs/Web/XPath/Snippets#getXPathForElement
@@ -138,15 +138,15 @@ export function getXPathForElement(targetElement: Node, offset: number, referenc
     pos = 1;
 
     while (element) {
-      // highlights in text change the number of nodes in the nodelist,
+      // highlights in text change the number of nodes in the nodelist,z
       // compensate by gobbling adjacent highlights and text
       if (isTextOrTextHighlightOrScreenReaderNode(focus) && isTextOrTextHighlightOrScreenReaderNode(element)) {
         while (isTextOrTextHighlightOrScreenReaderNode(element)) {
           element = element.previousSibling!;
         }
         pos += 1;
       } else {
-        if (isElementNotHighlight(focus) && isElementNotHighlight(element) && element.nodeName === focus.nodeName) {
+        if (isElementNotHighlight(focus) && isElementNotHighlight(element) && (element as Node).nodeName === (focus as Node).nodeName) {
           pos += 1;
         }
         element = element.previousSibling!;
@@ -222,7 +222,7 @@ export function getFirstByXPath(path: string, offset: number, referenceElement:
     node = null;
   }
 
-  if (isElement(node!) && node!.childNodes.length < offset) {
+  if (isElement(node!) && (node as Node).childNodes.length < offset) {
     node = null;
   }
 
@@ -234,7 +234,7 @@ function followPart(node: Node, part: string) {
   const findFirst = (nodeList: NodeList, predicate: (node: Node) => boolean) =>
     Array.prototype.find.call(nodeList, (node: Node) => predicate(node));
   const findFirstAfter = (nodeList: NodeList, afterThis: Node, predicate: (node: Node) => boolean) => findFirst(
-    Array.prototype.slice.call(nodeList, Array.prototype.indexOf.call(nodeList, afterThis) + 1),
+    Array.prototype.slice.call(nodeList, Array.prototype.indexOf.call(nodeList, afterThis) + 1) as unknown as NodeList,
     predicate
   );
 

yarn.lock

@@ -6008,16 +6008,16 @@ typescript-babel-jest@^1.0.5:
     babel-jest "20.0.3"
     typescript "^2.4.1"
 
-typescript@<3.2:
-  version "3.1.8"
-  resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.1.8.tgz#20703f388d9fccc562ca4a049d8a7567c8e95ebd"
-  integrity sha512-R97qglMfoKjfKD0N24o7W6bS+SwjN/eaQNIaxR8S5HdLRnt7rCk6LCmE3tve1KN8gXKgbJU51aZHRRMAQcIbMA==
-
 typescript@^2.4.1:
   version "2.9.2"
   resolved "https://registry.yarnpkg.com/typescript/-/typescript-2.9.2.tgz#1cbf61d05d6b96269244eb6a3bce4bd914e0f00c"
   integrity sha512-Gr4p6nFNaoufRIY4NMdpQRNmgxVIGMs4Fcu/ujdYk3nAZqk7supzBE9idmvfZIlH/Cuj//dvi+019qEue9lV0w==
 
+typescript@~3.5:
+  version "3.5.3"
+  resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.5.3.tgz#c830f657f93f1ea846819e929092f5fe5983e977"
+  integrity sha512-ACzBtm/PhXBDId6a6sDJfroT2pOWt/oOnk4/dElG5G33ZL776N3Y6/6bKZJBFpd+b05F3Ct9qDjMeJmRWtE2/g==
+
 uglify-js@^3.1.4:
   version "3.19.3"
   resolved "https://registry.yarnpkg.com/uglify-js/-/uglify-js-3.19.3.tgz#82315e9bbc6f2b25888858acd1fff8441035b77f"