Skip to content

Commit a321616

Browse files
committed
builder/windows: bump API version
binutils 2.43 is incompatible with older openslide-bin source releases. We could pin older binutils in the Windows builder container, but that's probably more backward compatibility glue than we want to maintain here. Bump the builder API version so older openslide-bin source releases will fail cleanly. Have bintool accept both API versions, since the new code should work with both. Signed-off-by: Benjamin Gilbert <bgilbert@cs.cmu.edu>
1 parent 88d1620 commit a321616

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

bintool

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ from common.meson import (
5050
)
5151
from common.software import Project
5252

53-
WINDOWS_API_VERS = (4,)
53+
WINDOWS_API_VERS = (4, 5)
5454
LINUX_API_VERS = (3,)
5555
# we have a higher minimum than the underlying meson.build
5656
MESON_MIN_VER = (1, 5, 0)

builder/windows/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ FROM docker.io/gentoo/stage3:latest
22
# NOTE: try to keep the current container image compatible with the latest
33
# stable source release, so people can conveniently build from the source
44
# tarball
5-
RUN touch /etc/openslide-winbuild-builder-v{3,4}
5+
RUN touch /etc/openslide-winbuild-builder-v5
66
RUN echo 'FEATURES="-sandbox -usersandbox -ipc-sandbox -network-sandbox -pid-sandbox"' >> /etc/portage/make.conf
77
COPY package.accept_keywords /etc/portage/package.accept_keywords/openslide
88
COPY package.use /etc/portage/package.use/openslide

0 commit comments

Comments
 (0)