Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USHIFT-4518: Add retries on rebasing bootc or ostree systems #3952

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

ggiguash
Copy link
Contributor

@ggiguash ggiguash commented Sep 22, 2024

An attempt to work around ostreedev/ostree-rs-ext#657 when running tests.
Note: The problem still persists when running rebase from kickstart, but it's handled by the virt-install restart in the scenario.sh script.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 22, 2024

@ggiguash: This pull request references USHIFT-4518 which is a valid jira issue.

In response to this:

An attempt to work around ostreedev/ostree-rs-ext#657 when running tests.
Note: The problem still persists when running rebase from kickstart.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 22, 2024
@openshift-ci openshift-ci bot requested review from copejon and jerpeter1 September 22, 2024 10:26
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2024
@ggiguash
Copy link
Contributor Author

/cherry-pick release-4.17

@openshift-cherrypick-robot

@ggiguash: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 23, 2024

@ggiguash: This pull request references USHIFT-4518 which is a valid jira issue.

In response to this:

An attempt to work around ostreedev/ostree-rs-ext#657 when running tests.
Note: The problem still persists when running rebase from kickstart, but it's handled by the virt-install restart in the scenario.sh script.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2024
Copy link
Contributor

openshift-ci bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD fa8e7de and 2 for PR HEAD 129e34e in total

Copy link
Contributor

openshift-ci bot commented Sep 23, 2024

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 13c795a into openshift:main Sep 23, 2024
8 checks passed
@openshift-cherrypick-robot

@ggiguash: #3952 failed to apply on top of branch "release-4.17":

Applying: Add retries on rebasing bootc or ostree systems
Using index info to reconstruct a base tree...
M	test/resources/ostree.resource
Falling back to patching base and 3-way merge...
Auto-merging test/resources/ostree.resource
CONFLICT (content): Merge conflict in test/resources/ostree.resource
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add retries on rebasing bootc or ostree systems
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants